Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to mount root filesystem: invalid mount config #1722

Closed
rogercoll opened this issue Sep 20, 2024 · 4 comments · Fixed by #1728
Closed

Unable to mount root filesystem: invalid mount config #1722

rogercoll opened this issue Sep 20, 2024 · 4 comments · Fixed by #1728
Labels
bug Something isn't working

Comments

@rogercoll
Copy link
Contributor

Bug Report

$ cat .git/config | rg url
        url = git@github.com:open-telemetry/opentelemetry-demo.git
$ make start
docker compose --env-file .env --env-file .env.override up --force-recreate --remove-orphans --detach
[+] Running 7/8
 ✔ Container flagd        Recreated                                                      0.1s
 ✔ Container kafka        Recreated                                                      0.1s
 ✔ Container jaeger       Recreated                                                      0.1s
 ✔ Container prometheus   Recreated                                                      0.1s
 ✔ Container grafana      Recreated                                                      0.1s
 ✔ Container opensearch   Recreated                                                      0.1s
 ✔ Container valkey-cart  Recreated                                                      0.1s
 ⠋ Container otel-col     Creating                                                       0.0s
Error response from daemon: invalid mount config: must use either propagation mode "rslave" or "rshared" when mount source is within the daemon root, daemon root: "/var/lib/docker", bind mount source: "/", propagation: "rprivate"
make: *** [Makefile:130: start] Error 1

Symptom

After docker being upgraded, current version: 27.2.1

What do you expect to see? No error mounting the root filesystem in the opentelemetry collector

@rogercoll rogercoll added the bug Something isn't working label Sep 20, 2024
@rogercoll
Copy link
Contributor Author

It seems that this change fixes the issue:

diff --git a/docker-compose.yml b/docker-compose.yml
index e253cdc..9696857 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -695,7 +695,7 @@ services:
     command: [ "--config=/etc/otelcol-config.yml", "--config=/etc/otelcol-config-extras.yml" ]
     user: 0:0
     volumes:
-      - ${HOST_FILESYSTEM}:/hostfs:ro
+      - ${HOST_FILESYSTEM}:/hostfs:ro,rslave

Has anyone experienced the same failure?

@julianocosta89
Copy link
Member

I'm not getting this error, but adding rslave didn't crash, so I'd suggest adding it to the upstream compose and compose.minimal.

@julianocosta89
Copy link
Member

@rogercoll I have an opened PR that changes the otel-col, you could add the rslave there if you would like.
#1724

@rogercoll
Copy link
Contributor Author

Thanks for the check @julianocosta89 ! I have just opened a new PR so we have more scoped PRs #1728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants