fix: mount host filesystem as bind rslave mount #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
|
Tested on a Linux environment, @open-telemetry/demo-approvers It would be very appreciated if someone else could test these changes on their end too. Thanks! |
julianocosta89
approved these changes
Sep 30, 2024
|
@rogercoll I'll merge this one, and we can investigate further if any windows user starts to get any errors. |
benakansara
pushed a commit
to benakansara/opentelemetry-demo
that referenced
this pull request
Oct 15, 2024
* fix: mount host filesystem as bind rslave mount * chore: add changelog entry --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
benakansara
pushed a commit
to elastic/opentelemetry-demo
that referenced
this pull request
Oct 15, 2024
* fix: mount host filesystem as bind rslave mount * chore: add changelog entry --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
benakansara
added a commit
to elastic/opentelemetry-demo
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1722
See docker/compose#12139 (since Docker compose v2.29.6)
Bind mounts documentation: https://docs.docker.com/engine/storage/bind-mounts/#configure-bind-propagation
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions* [ ] Appropriate documentation updates in the docs* [ ] Appropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.