Unify offset data model #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2023
Closed
This comment was marked as outdated.
This comment was marked as outdated.
This hasn't changed (https://cs.opensource.google/go/go/+/refs/tags/go1.21.1:src/net/url/url.go;l=362), but the tooling is broke (#271).
MrAlias
force-pushed
the
unify-offset-data-model
branch
from
6a4ce16
to
a11c3f3
Compare
pellared
approved these changes
Sep 19, 2023
pdelewski
reviewed
Sep 21, 2023
pdelewski
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offsets generation currently uses a copy of the
pkg/injectdata model, this introduces a bug if they become out of sync. This change unifies on thepkg/injectdata model to be used for both. It also adds a helper method to theTrackedOffsetsto remove duplicate lookup logic in both packages.Resolves #291