Automate post-release step #12463
Merged
Automate post-release step #12463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
automate-post-release
branch
from
decd63b
to
362bd33
Compare
trask
force-pushed
the
automate-post-release
branch
from
362bd33
to
5129766
Compare
laurit
reviewed
Oct 18, 2024
| --fail \ | ||
| https://repo1.maven.org/maven2/io/opentelemetry/javaagent/opentelemetry-javaagent/$VERSION/opentelemetry-javaagent-$VERSION.jar | ||
| do | ||
| sleep 60 |
There was a problem hiding this comment.
There is a timeout for github actions so the workflow would get killed after 6h (i think) guess that should be enough. An alternative would be to use something similar to cloudfoundry index updates that are run periodically and query the maven metadata for the latest version. Though would need to figure out how to get the previous version then.
There was a problem hiding this comment.
yeah, the artifacts have been showing up pretty quickly in maven central lately, though I haven't been paying super close attention, it will be interesting to see exactly how long this step runs
laurit
approved these changes
Oct 18, 2024
zeitlinger
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't test this, will just try it out next release, worst case I just have to make the post-release PR manually again...
Closes #11612