Pass unmodifiable list to exporters (#2938)

open-telemetry · Feb 26, 2021 · 0d467ab · 0d467ab
1 parent f1c38ef
commit 0d467ab
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessor.java b/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessor.java
@@ -18,6 +18,7 @@
 import io.opentelemetry.sdk.trace.SpanProcessor;
 import io.opentelemetry.sdk.trace.data.SpanData;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.TimeUnit;
@@ -261,7 +262,8 @@ private void exportCurrentBatch() {
       }
 
       try {
-        final CompletableResultCode result = spanExporter.export(batch);
+        final CompletableResultCode result =
+            spanExporter.export(Collections.unmodifiableList(batch));
         result.join(exporterTimeoutNanos, TimeUnit.NANOSECONDS);
         if (result.isSuccess()) {
           exportedSpans.add(batch.size());