Refactor the relabel loop

open-telemetry · Nov 6, 2024 · 221cc8e · 221cc8e
1 parent 11ae3ea
commit 221cc8e
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/cmd/otel-allocator/prehook/relabel.go b/cmd/otel-allocator/prehook/relabel.go
@@ -43,18 +43,15 @@ func (tf *RelabelConfigTargetFilter) Apply(targets map[string]*target.Item) map[
 
 	// Note: jobNameKey != tItem.JobName (jobNameKey is hashed)
 	for jobNameKey, tItem := range targets {
-		keepTarget := true
+		var keepTarget bool
 		lset := tItem.Labels
 		for _, cfg := range tf.relabelCfg[tItem.JobName] {
 			lset, keepTarget = relabel.Process(lset, cfg)
 			if !keepTarget {
+				delete(targets, jobNameKey)
 				break // inner loop
 			}
 		}
-
-		if !keepTarget {
-			delete(targets, jobNameKey)
-		}
 	}
 
 	tf.log.V(2).Info("Filtering complete", "seen", numTargets, "kept", len(targets))