Create service for extensions #3403
Conversation
Ankit152
force-pushed
the
service-extension
branch
from
df4a731
to
3a5a2ee
Compare
Ankit152
force-pushed
the
service-extension
branch
from
3a5a2ee
to
3ab8c98
Compare
| return nil, err | ||
| } | ||
|
|
||
| ports, err := params.OtelCol.Spec.Config.GetExtensionPorts(params.Log) |
There was a problem hiding this comment.
If there are no ports... maybe we can just not create the service
There was a problem hiding this comment.
Do you mean something similar to this?
if len(ports) == 0 {
return nil, nil
}
Also, if there are ports, will it be a good idea to add HA proxy for them similar to this?
There was a problem hiding this comment.
Yes. That's what I meant.
I'm not sure about the HA. Do we need GRPC for this?
There was a problem hiding this comment.
Yes. That's what I meant.
I have already implemented that and written proper unit tests for the same.
Although, I have a suggestion/doubt. Won't it be a good idea to add labels in the extension service similar to these?
There was a problem hiding this comment.
Do we need GRPC for this?
@yurishkuro can you answer this?
There was a problem hiding this comment.
Jaeger extension exposes both http and grpc endpoints.
| return nil, err | ||
| } | ||
|
|
||
| ports, err := params.OtelCol.Spec.Config.GetExtensionPorts(params.Log) |
Ankit152
force-pushed
the
service-extension
branch
from
a683b66
to
d742325
Compare
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
Ankit152
force-pushed
the
service-extension
branch
from
d742325
to
eb14bf7
Compare
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
Ankit152
force-pushed
the
service-extension
branch
from
eb14bf7
to
5f26d14
Compare
Description:
The Otel Operator doesn't creates a service for extensions. This will help the operator to create Service for extensions which will be consumed by an Ingress so that users can interact with it directly. This is related to deployment of Jaeger V2 in k8s.
Link to tracking Issue(s):
Testing:
Documentation: