Packaging - Moving to pyproject.toml #38
Conversation
conda/meta.yaml
Outdated
| @@ -11,15 +11,16 @@ build: | |||
| noarch: python | |||
| preserve_egg_dir: True | |||
| number: 2 | |||
| script: {{PYTHON}} setup.py install #--single-version-externally-managed --record=record.txt | |||
| #script: {{PYTHON}} setup.py install #--single-version-externally-managed --record=record.txt | |||
| script: {{ PYTHON }} -m pip install . | |||
There was a problem hiding this comment.
Do we need other options to pip install?
There was a problem hiding this comment.
I would sugger to use:
--no-deps Don't install package dependencies.
conda/meta.yaml
Outdated
|
|
||
| requirements: | ||
| build: | ||
| - python {{PY_VER}} | ||
| - setuptools | ||
| - openalea.deploy | ||
| run: | ||
| - python >=3.6 | ||
| - python >=3.10 |
There was a problem hiding this comment.
Is Python 3.10 mandatory? Or can we have Python 3.7 or 3.8 as a minimal version?
pyproject.toml
Outdated
| ] | ||
| license = { text = "CeCILL-C" } | ||
| keywords = ["OpenAlea", "MTG", "Plant Architecture", "Tree Graph"] | ||
| dependencies = [] |
There was a problem hiding this comment.
Add the dependencies.
Document needed vs optional dependencies
| #version = {file = "src/openalea/mtg/version.py"} | ||
|
|
||
| #[tool.setuptools.entry-points.wralea] | ||
| #mtg = "openalea.mtg_wralea" |
There was a problem hiding this comment.
entry-point are also important both in pyproject.toml and conda/meta.yaml
tests/data/leaf_axis.drf
Outdated
| # contains symbol a_leaf | ||
|
|
||
| Class F = feuille | ||
| SMBPath = D:/Documents/pradal/devlp/vplants/aml/databases/SMBFiles |
There was a problem hiding this comment.
PATh are only valid on windows on a specific computer. Make this system independent
There was a problem hiding this comment.
Where should be located this folder (SMBFiles) ? It does not appear to be in the git repo
| keywords = ["OpenAlea", "MTG", "Plant Architecture", "Tree Graph"] | ||
|
|
||
| dependencies = [ | ||
| "openalea.plantgl", |
There was a problem hiding this comment.
openalea.plantgl is not pip installable. Is it a problem?
| """(int) Version minor component.""" | ||
|
|
||
| post = 0 | ||
| post = 1 |
No description provided.