New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix truncation of results in phased queries where checkAminoAcidChange=TRUE #690

Open

julie-sullivan wants to merge 1 commit into opencb:develop from julie-sullivan:develop

Contributor

julie-sullivan commented May 10, 2024

Please see Todd's document for a full description of the bug, but here is a summary:

example query input: 1:100:A:G with parameters: checkAminoAcidChange = true, ignorePhase=false
HGVS value is used to query results not the variant coordinates e.g. p.Met1?
Query results may include more than one variant matching p.Met1?: 4. e.g. 1:100:A:G (3 trait associations) 1:101:A:G (2 trait associations) 1:101:T:C (7 trait associations)
code picks the first result and ignores the rest.

Also we have a unit test but it uses mockito. Do you want it anyway?

15:90766924:T:G,15:90766927:G:T were the original problematic variants.


          fix truncation of results in phased queries where checkAminoAcidChang…

c627596

…e=TRUE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet