fix(list): skip reminders with a missing calendar

[SebTardif]

What Problem This Solves

remindctl list force-unwraps reminder.calendar. An orphaned EventKit reminder with a missing calendar traps the process.

Why This Change Was Made

EventKit exposes calendar as an implicitly unwrapped optional. Nil is a real store state, not a programmer error.

User Impact

remindctl list skips the orphaned row and prints the rest of the list.

Evidence

terminal output from the calendar mapping helper:

$ swift test --filter ReminderCalendarMappingTests
Test Suite ReminderCalendarMappingTests passed

Real behavior proof

Behavior addressed: Reminders with a nil calendar are skipped instead of trapping list.
Real environment tested: macOS, Swift toolchain, clone at /tmp/pr-remindctl on the patched branch.
Exact steps or command run after this patch: swift test --filter ReminderCalendarMappingTests
Evidence after fix: terminal output copied below.

$ swift test --filter ReminderCalendarMappingTests
Test Suite ReminderCalendarMappingTests passed

Observed result after fix: A nil calendar id maps to skip. A present id still produces a list identity.
What was not tested: A live EventKit store that already contains an orphaned reminder.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

[clawsweeper]

Codex review: needs real behavior proof before merge. Reviewed August 27, 2026, 8:17 AM ET / 12:17 UTC.

ClawSweeper review

What this changes

The PR makes reminder listing skip EventKit reminders with no calendar identity, adding a small mapping helper and coverage for missing and present calendar values.

Merge readiness

⛔ Blocked until real behavior proof from a real setup is added - 3 items remain

This PR remains necessary: current main still force-dereferences reminder.calendar while converting fetched reminders. The patch is focused and has no discrete correctness finding, but it needs real EventKit behavior proof before merge.

Priority: P2
Reviewed head: a046f57088c85a1dbd98069bdc3422317f983e13

Review scores

Measure	Result	What it means
Overall readiness	🦪 silver shellfish (2/6)	The implementation is focused and source-supported, but the reported real EventKit state has not been demonstrated after the fix.
Proof confidence	🦪 silver shellfish (2/6)	Needs real behavior proof before merge: The PR provides a focused helper-test transcript but no live EventKit orphaned-reminder run; add redacted after-fix macOS terminal evidence that remindctl list skips the row and continues before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Needs proof	Needs real behavior proof before merge: The PR provides a focused helper-test transcript but no live EventKit orphaned-reminder run; add redacted after-fix macOS terminal evidence that remindctl list skips the row and continues before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed	4 items	Current-main unsafe conversion: Current main reads reminder.calendar.calendarIdentifier and .title directly while mapping fetched reminders, so the reported nil-calendar crash path is not already fixed. Patch boundary: The PR treats the EventKit calendar as optional, returns nil for a missing identity, and uses compactMap so only the orphaned row is omitted. Focused synthetic coverage: Tests cover absent calendar identifiers, valid identity preservation, and compact-mapping of an orphaned row, but do not instantiate or fetch an EventKit reminder from a real store.
Findings	None	None.
Security	None	None.

Live Verification

Command: swift run remindctl list --help

Result: FAIL (failed) — execution before step 1 expect_output: terminal command did not produce output or exit within 30 seconds: "swift run remindctl list --help"

terminal command did not produce output or exit within 30 seconds: "swift run remindctl list --help"

Captured output:

Assertions:

• FAIL expect_output: List reminder lists or show list contents

How this fits together

The remindctl list command asks RemindCore to fetch EventKit reminders, converts them into reminder rows, and renders the result in the terminal. This change sits at the EventKit-to-RemindCore conversion boundary before list output.

flowchart LR
  A[EventKit reminder store] --> B[Reminder fetch]
  B --> C[Calendar identity mapping]
  C -->|calendar present| D[Reminder snapshot]
  C -->|calendar missing| E[Skip orphaned row]
  D --> F[List command]
  F --> G[Terminal output]

Loading

Before merge

• Add real behavior proof - Needs real behavior proof before merge: The PR provides a focused helper-test transcript but no live EventKit orphaned-reminder run; add redacted after-fix macOS terminal evidence that remindctl list skips the row and continues before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
• Resolve merge risk (P1) - The supplied transcript only runs a helper-level Swift test and explicitly omits a live EventKit store containing an orphaned reminder, so command-level recovery remains unproven.
• Complete next step (P2) - The contributor needs to supply real EventKit behavior proof before a human merge decision; no mechanical repair finding requires an automation lane.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Patch size	production +67/-42; tests +38; 3 files affected	The functional guard is small, while most production churn extracts the existing snapshot conversion.

Merge-risk options

Maintainer options:

1. Decide the mitigation before merge
   Keep the optional-calendar guard at the EventKit snapshot boundary and support it with a redacted macOS run showing remindctl list continues after encountering an orphaned reminder.
2. Pause or close
   Do not merge this PR until maintainers decide whether the risk is worth taking.

Technical review

Best possible solution:

Keep the optional-calendar guard at the EventKit snapshot boundary and support it with a redacted macOS run showing remindctl list continues after encountering an orphaned reminder.

Do we have a high-confidence way to reproduce the issue?

No high-confidence live reproduction is provided. Current main directly dereferences the calendar during fetched-reminder conversion, while the PR’s evidence exercises only a synthetic mapping helper.

Is this the best way to solve the issue?

Yes; handling the optional calendar at the EventKit snapshot boundary is the narrowest maintainable repair and leaves command rendering unchanged.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning high; reviewed against df4b872c1646.

Labels

Label justifications:

• P2: This repairs a crash in a narrow reminder-listing edge case with limited demonstrated blast radius.
• rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
• status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR provides a focused helper-test transcript but no live EventKit orphaned-reminder run; add redacted after-fix macOS terminal evidence that remindctl list skips the row and continues before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Evidence

What I checked:

• Current-main unsafe conversion: Current main reads reminder.calendar.calendarIdentifier and .title directly while mapping fetched reminders, so the reported nil-calendar crash path is not already fixed. (Sources/RemindCore/EventKitStore.swift:268, df4b872c1646)
• Patch boundary: The PR treats the EventKit calendar as optional, returns nil for a missing identity, and uses compactMap so only the orphaned row is omitted. (Sources/RemindCore/EventKitStore.swift:242, a046f57088c8)
• Focused synthetic coverage: Tests cover absent calendar identifiers, valid identity preservation, and compact-mapping of an orphaned row, but do not instantiate or fetch an EventKit reminder from a real store. (Tests/RemindCoreTests/ReminderCalendarMappingTests.swift:6, a046f57088c8)
• Current-source provenance: Blame attributes the current-main fetch conversion to the v0.3.4 release snapshot; the later current-main commit only changes CI permissions, so main has not absorbed this fix. (Sources/RemindCore/EventKitStore.swift:268, 762ff39a6290)

Likely related people:

• Peter Steinberger: The current-main unsafe conversion is attributed by blame to the v0.3.4 source snapshot authored by Peter Steinberger. (role: current source provenance; confidence: medium; commits: 762ff39a6290; files: Sources/RemindCore/EventKitStore.swift)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

• Add a redacted macOS terminal transcript or recording showing remindctl list continue past an orphaned EventKit reminder.
• Update the PR body with that evidence; if review does not restart, ask a maintainer to comment @clawsweeper re-review.

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (25 earlier review cycles; latest 8 shown)

• reviewed 2026-08-24T22:58:20.251Z sha a046f57 :: needs real behavior proof before merge. :: none
• reviewed 2026-08-25T03:13:31.733Z sha a046f57 :: needs real behavior proof before merge. :: none
• reviewed 2026-08-25T11:05:02.198Z sha a046f57 :: needs real behavior proof before merge. :: none
• reviewed 2026-08-25T17:05:52.654Z sha a046f57 :: needs real behavior proof before merge. :: none
• reviewed 2026-08-26T00:00:32.390Z sha a046f57 :: needs real behavior proof before merge. :: none
• reviewed 2026-08-26T06:00:21.795Z sha a046f57 :: needs real behavior proof before merge. :: none
• reviewed 2026-08-26T17:11:10.434Z sha a046f57 :: needs real behavior proof before merge. :: none
• reviewed 2026-08-26T22:44:30.770Z sha a046f57 :: needs real behavior proof before merge. :: none