Feat: "Add to Home screen" option to create folder shortcuts with deep link - #219
Open
Lightz2002 wants to merge 1 commit into
Open
Feat: "Add to Home screen" option to create folder shortcuts with deep link#219Lightz2002 wants to merge 1 commit into
Lightz2002 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deep-linking straight into that folder when tapped.
Changes
ADD_TO_HOME_SCREENtoFileMenuOptionand wire it into the file actions menu(
action_add_to_home) with a new icon; only shown for single-selected folders viaFilterFileMenuOptionsUseCaseAddToHomeScreenDialogFragment: pre-filled, editable shortcut name with validation(empty name, max filename length, forbidden characters)
FolderShortcutHelper: creates a pinned shortcut viaShortcutManager(API 26+),embedding the folder's remote ID, remote path, and space ID in the intent
FileDisplayActivityhandles the newOPEN_SHORTCUTaction: resolves the folder byremote path + space ID from local storage and navigates directly into it; extras are
consumed after handling; shows an error snackbar if the folder no longer exists locally
Notes
Testing