fix(design-system): useIsVisible observer look-ahead - #3210
Open
JammingBen wants to merge 1 commit into
Open
Conversation
Fixes the look-ahead of the useIsVisible composable by passing it the parent scroll container as root property and creating the observer lazily to ensure the target element is mounted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the look-ahead of the
useIsVisiblecomposable by passing it the parent scroll container asrootproperty and creating the observer lazily to ensure the target element is mounted.You can test this by adjusting your browser window size so it fits e.g. 15 tiles in the file list. Now open a folder with >30 images and look at the network tab. It should load ~30 thumbnails because of the fixed look-ahead, which is now about one viewport.
fixes #3168