Skip to content

feat: redesign plain layout pages - #3232

Merged
JammingBen merged 4 commits into
mainfrom
feat/redesign-plain-layout
Aug 27, 2026
Merged

feat: redesign plain layout pages#3232
JammingBen merged 4 commits into
mainfrom
feat/redesign-plain-layout

Conversation

@JammingBen

@JammingBen JammingBen commented Aug 26, 2026

Copy link
Copy Markdown
Member

Redesign the plain layout pages and reduce the flicker after logging in and out and when resolving private links by:

  • matching the initial loading spinner and the AppLoadingSpinner.
  • matching the background colors of the initial page render and the loaded theme.
  • introducing a new bare layout that only renders the AppLoadingSpinner to avoid rendering some text like You are being logged in for a split second.

Also, make using dark: prefixes on Tailwind classes work by correctly setting document.documentElement.dataset.colorScheme.

image

Redesign the plain layout pages and reduce the flicker after logging in
and out and when resolving private links by:

- matching the initial loading spinner and the AppLoadingSpinner.
- matching the background colors of the initial page render and the
  loaded theme.
- introducing a new bare layout that only renders the AppLoadingSpinner
  to avoid rendering some text for a split second.
@JammingBen
JammingBen force-pushed the feat/redesign-plain-layout branch from 9ef868f to 096e987 Compare August 26, 2026 14:08
@JammingBen
JammingBen marked this pull request as ready for review August 26, 2026 14:17
@JammingBen

Copy link
Copy Markdown
Member Author

@kulmann I'm a bit undecided on the You are being logged in part. It previously appeared directly after login for a split second (depending on the network). But it doesn't really add much value and just states the obvious (if the user is fast enough to read it in the first place). So I just expanded the loading spinner a bit longer instead. What do you think?

@JammingBen
JammingBen requested a review from kulmann August 26, 2026 14:22
@kulmann

kulmann commented Aug 27, 2026

Copy link
Copy Markdown
Member

@kulmann I'm a bit undecided on the You are being logged in part. It previously appeared directly after login for a split second (depending on the network). But it doesn't really add much value and just states the obvious (if the user is fast enough to read it in the first place). So I just expanded the loading spinner a bit longer instead. What do you think?

Yes, much better. Having a text that is only briefly there might cause the typical confusion of "I was not fast enough to read it, what was that? did something bad happen?". loading spinner is sufficient. 馃憤

Comment thread packages/web-runtime/src/composables/layout/useLayout.ts
@JammingBen
JammingBen requested a review from kulmann August 27, 2026 05:03
Comment thread packages/web-runtime/src/layouts/Plain.vue Outdated

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice improvement 馃

@JammingBen
JammingBen merged commit ca3e58d into main Aug 27, 2026
31 checks passed
@JammingBen
JammingBen deleted the feat/redesign-plain-layout branch August 27, 2026 08:22
@openclouders openclouders mentioned this pull request Aug 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants