Make bv_automata fallible
#670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be sensible. Should we merge it for now? |
|
I'm confused about the CI failure. The error is that it doesn't have permission to add the comment to PR with the Alive stats, but it works for other PRs... |
|
I guess our CI only works for branches within the repo. Can you just create your branch within the repo and see if it goes through? |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Same as #670 but from a branch on the main repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
bv_automatadoes not fail if the goal is false, becausenative_decidedoesn't fail, it produces an ill-typed proof.On consequence is that it is awkward to use
bv_automatain a tactic such asbv_auto, since it relied on tactics to fail to be able to try the next tactic (cf issue #660) It also give an error that is not helpful at all after the proof is complete.This PR is a proof of concept that modifies the implementation of
native_decideto check that the problem is solved by the decision procedure before constructing the proof object.