Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specs-go: sync SCMP_ARCH_* constants with libseccomp main #1229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

specs-go: sync SCMP_ARCH_* constants with libseccomp main #1229

wants to merge 1 commit into from
+27 −0

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Sep 26, 2023 •
edited
Loading

The following constants are defined in the main branch of libseccomp, but not included in its latest release (v2.5) yet:

These constant names are unlikely to change before v2.6 GA, so we can safely refer to them in specs-go.

Replaces:

@AkihiroSuda
specs-go: sync SCMP_ARCH_* constants with libseccomp main
eb1dc7d 
The following constants are defined in the main branch of libseccomp,
but not included in its latest release (v2.5) yet:

* SCMP_ARCH_LOONGARCH64  (seccomp/libseccomp@6966ec7)
* SCMP_ARCH_M68K         (seccomp/libseccomp@dd5c9c2)
* SCMP_ARCH_SH           (seccomp/libseccomp@c12945d)
* SCMP_ARCH_SHEB         (seccomp/libseccomp@c12945d)

These constant names are unlikely to change before v2.6 GA,
so we can safely refer to them in specs-go.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the v1.1.1 milestone Sep 26, 2023
@AkihiroSuda
Copy link
Member Author

Ideally we should just wait for libseccomp v2.6 GA, but new releases don't seem to be going to happen very soon

@AkihiroSuda AkihiroSuda mentioned this pull request Sep 26, 2023
Open
@thaJeztah
Copy link
Member

Ideally we should just wait for libseccomp v2.6 GA, but new releases don't seem to be going to happen very soon

Would there be any consequences if this arch is used in a profile, but the libseccomp version that's used doesn't have it yet? (sorry, I'm lazy, thought I'd ask as maybe you know from the top of your head); bad memories of those cases where certain distros only had outdated versions 😓

@AkihiroSuda
Copy link
Member Author

Ideally we should just wait for libseccomp v2.6 GA, but new releases don't seem to be going to happen very soon

Would there be any consequences if this arch is used in a profile, but the libseccomp version that's used doesn't have it yet? (sorry, I'm lazy, thought I'd ask as maybe you know from the top of your head); bad memories of those cases where certain distros only had outdated versions 😓

The runtime impl will raise an error. (Same as other archs)

@utam0k utam0k mentioned this pull request Sep 28, 2023
Open
utam0k
utam0k reviewed Sep 28, 2023
View reviewed changes
config-linux.md
Comment on lines +746 to +755
<!--
The following constants are defined in the main branch of libseccomp,
but not included in its latest release (v2.5) yet:
https://github.com/seccomp/libseccomp/commits/main/include/seccomp.h.in

* SCMP_ARCH_LOONGARCH64
* SCMP_ARCH_M68K
* SCMP_ARCH_SH
* SCMP_ARCH_SHEB
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue and assigned it to me so that we would not forget to update it.
#1231

@AkihiroSuda
Copy link
Member Author

@kolyshkin PTAL

@AkihiroSuda
Copy link
Member Author

ping @kolyshkin 🙏

@AkihiroSuda AkihiroSuda removed this from the v1.1.1 milestone Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

@crosbymichael crosbymichael Awaiting requested review from crosbymichael crosbymichael is a code owner

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

@dqminh dqminh Awaiting requested review from dqminh dqminh is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe giuseppe is a code owner

@hqhq hqhq Awaiting requested review from hqhq hqhq is a code owner

@kolyshkin kolyshkin Awaiting requested review from kolyshkin kolyshkin is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@thaJeztah thaJeztah Awaiting requested review from thaJeztah thaJeztah is a code owner

@tianon tianon Awaiting requested review from tianon tianon is a code owner

@vbatts vbatts Awaiting requested review from vbatts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @thaJeztah @utam0k