Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions smoke test #123

Merged

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Oct 23, 2023

Description

Use a github actions workflow to run the docker-compose smoke test. This PR also updates the smoke test itself to use less storage space by using the built container to convert the image to a caikit-compatible format, as well as other minor fixes related to usage in CI environments.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dtrifiro dtrifiro force-pushed the add-github-actions-smoke-test branch 3 times, most recently from 73efe33 to c9ba3f3 Compare October 24, 2023 13:43
@dtrifiro dtrifiro marked this pull request as ready for review October 24, 2023 13:49
@dtrifiro dtrifiro force-pushed the add-github-actions-smoke-test branch 7 times, most recently from b3faf9c to 558151d Compare October 24, 2023 16:47
@dtrifiro dtrifiro requested a review from Xaenalt October 24, 2023 16:57
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtrifiro dtrifiro merged commit a613b85 into opendatahub-io:main Oct 24, 2023
2 checks passed
@dtrifiro
Copy link
Contributor Author

Closes #7

@dtrifiro dtrifiro deleted the add-github-actions-smoke-test branch October 26, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants