Unit tests #34
Unit tests #34
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Xaenalt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Xaenalt
force-pushed
the
unit-tests
branch
4 times, most recently
from
89cde72
to
f2dfba7
Compare
|
Need to properly rebase this, since I ended up writing this on the branch I was working on other stuff on /hold |
Makefile
Outdated
|
|
||
| docker-test: default | ||
| podman run -it --rm \ | ||
| -e DTYPE_STR=float32 \ |
There was a problem hiding this comment.
Is it possible to move this conf to the template? My understanding is that it is necessary to run on CPU. Correct?
There was a problem hiding this comment.
It is, but we don't want to set it universally, since GPU workloads may need to set it differently
There was a problem hiding this comment.
Ok, do you suggest to document that this option is necessary to run on CPU?
Here is a bit hidden in the script
There was a problem hiding this comment.
It's not needed forever, need is only based on IBM/text-generation-inference#7
There was a problem hiding this comment.
By the time we're ready for release, should hopefully no longer be necessary
Xaenalt
force-pushed
the
unit-tests
branch
6 times, most recently
from
d0a33dd
to
6a9d02e
Compare
|
/unhold |
Added piplock refresh
No description provided.