Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NLTK to patch CVE-2024-39705 #342

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Xaenalt
Copy link
Member

@Xaenalt Xaenalt commented Aug 13, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from rpancham and z103cb August 13, 2024 15:07
Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xaenalt Xaenalt merged commit b8de780 into opendatahub-io:main Aug 13, 2024
5 of 7 checks passed
@Xaenalt
Copy link
Member Author

Xaenalt commented Aug 13, 2024

/cherrypick release

@openshift-cherrypick-robot

@Xaenalt: only opendatahub-io org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Xaenalt
Copy link
Member Author

Xaenalt commented Aug 13, 2024

/cherrypick release

@openshift-cherrypick-robot

@Xaenalt: #342 failed to apply on top of branch "release":

Applying: Update NLTK to patch CVE-2024-39705
Using index info to reconstruct a base tree...
M	poetry.lock
Falling back to patching base and 3-way merge...
Auto-merging poetry.lock
CONFLICT (content): Merge conflict in poetry.lock
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update NLTK to patch CVE-2024-39705
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtrifiro
Copy link
Contributor

CI has been failing since this was merged:

#12 86.80 
#12 86.80   RuntimeError
#12 86.80 
#12 86.80   Unable to find installation candidates for nltk (3.8.2)
#12 86.80 
#12 86.80   at /usr/local/lib/python3.11/site-packages/poetry/installation/chooser.py:74 in choose_for
#12 86.81        70│ 
#12 86.81        71│             links.append(link)
#12 86.81        72│ 
#12 86.81        73│         if not links:
#12 86.81     →  74│             raise RuntimeError(f"Unable to find installation candidates for {package}")
#12 86.81        75│ 
#12 86.81        76│         # Get the best link
#12 86.81        77│         chosen = max(links, key=lambda link: self._sort_key(package, link))
#12 86.81        78│ 
#12 86.81 
#12 86.81 Cannot install nltk.

This is due to nltk 3.8.2 being deleted from pypi:
https://pypi.org/project/nltk/#history

See nltk/nltk#3301 for more context

and #346 for a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants