Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update caikit-nlp to 6f09931 #85

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Update caikit-nlp to 6f09931 #85

merged 1 commit into from
Oct 2, 2023

Conversation

Xaenalt
Copy link
Member

@Xaenalt Xaenalt commented Sep 19, 2023

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@Jooho
Copy link
Contributor

Jooho commented Oct 2, 2023

@Xaenalt do we have a doc to explain the flow of how to update tgis + caikit-nlp?

Jooho
Jooho approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 646898b into opendatahub-io:main Oct 2, 2023
3 checks passed
@Xaenalt
Copy link
Member Author

Xaenalt commented Oct 2, 2023

Oh xD I was going to merge this after we updated TGIS

@Xaenalt Xaenalt linked an issue Oct 12, 2023 that may be closed by this pull request
Sync image with TGIS updates opendatahub-io/text-generation-inference#26
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jooho Jooho Jooho approved these changes

@VedantMahabaleshwarkar VedantMahabaleshwarkar Awaiting requested review from VedantMahabaleshwarkar

Assignees
No one assigned
Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync image with TGIS updates
3 participants
@Xaenalt @Jooho @openshift-merge-robot