Skip to content

Commit

Permalink
Merge pull request #677 from HumairAK/stable
Browse files Browse the repository at this point in the history
[cherry-pick] increase default expiry for signed url
  • Loading branch information
HumairAK authored Jul 24, 2024
2 parents d3ae899 + f4c3873 commit 8469ebf
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions api/v1alpha1/dspipeline_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ type APIServer struct {

// The expiry time (seconds) for artifact download links when
// querying the dsp server via /apis/v2beta1/artifacts/{id}?share_url=true
// Default: 15
// +kubebuilder:default:=15
// Default: 60
// +kubebuilder:default:=60
// +kubebuilder:validation:Optional
ArtifactSignedURLExpirySeconds *int `json:"artifactSignedURLExpirySeconds"`
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ spec:
type: string
type: object
artifactSignedURLExpirySeconds:
default: 15
default: 60
description: 'The expiry time (seconds) for artifact download
links when querying the dsp server via /apis/v2beta1/artifacts/{id}?share_url=true
Default: 15'
Default: 60'
type: integer
autoUpdatePipelineDefaultVersion:
default: true
Expand Down
2 changes: 1 addition & 1 deletion controllers/config/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const (
DefaultDBSecretKey = "password"
GeneratedDBPasswordLength = 12

DefaultSignedUrlExpiryTimeSeconds = 15
DefaultSignedUrlExpiryTimeSeconds = 60

MariaDBName = "mlpipeline"
MariaDBHostPrefix = "mariadb"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ spec:
- name: ML_PIPELINE_SERVICE_PORT_GRPC
value: "8887"
- name: SIGNED_URL_EXPIRY_TIME_SECONDS
value: "15"
value: "60"
- name: EXECUTIONTYPE
value: PipelineRun
- name: CACHE_IMAGE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ spec:
- name: ML_PIPELINE_SERVICE_PORT_GRPC
value: "8887"
- name: SIGNED_URL_EXPIRY_TIME_SECONDS
value: "15"
value: "60"
- name: EXECUTIONTYPE
value: PipelineRun
- name: CACHE_IMAGE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ spec:
- name: ML_PIPELINE_SERVICE_PORT_GRPC
value: "8887"
- name: SIGNED_URL_EXPIRY_TIME_SECONDS
value: "15"
value: "60"
- name: EXECUTIONTYPE
value: PipelineRun
- name: CACHE_IMAGE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ spec:
- name: ML_PIPELINE_SERVICE_PORT_GRPC
value: "8887"
- name: SIGNED_URL_EXPIRY_TIME_SECONDS
value: "15"
value: "60"
- name: EXECUTIONTYPE
value: PipelineRun
- name: CACHE_IMAGE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ spec:
- name: ML_PIPELINE_SERVICE_PORT_GRPC
value: "8887"
- name: SIGNED_URL_EXPIRY_TIME_SECONDS
value: "15"
value: "60"
- name: EXECUTIONTYPE
value: PipelineRun
- name: CACHE_IMAGE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ spec:
- name: ML_PIPELINE_SERVICE_PORT_GRPC
value: "8887"
- name: SIGNED_URL_EXPIRY_TIME_SECONDS
value: "15"
value: "60"
- name: EXECUTIONTYPE
value: Workflow
- name: DB_DRIVER_NAME
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ spec:
- name: ML_PIPELINE_SERVICE_PORT_GRPC
value: "8887"
- name: SIGNED_URL_EXPIRY_TIME_SECONDS
value: "15"
value: "60"
- name: ML_PIPELINE_TLS_ENABLED
value: "true"
- name: EXECUTIONTYPE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ spec:
- name: ML_PIPELINE_SERVICE_PORT_GRPC
value: "8887"
- name: SIGNED_URL_EXPIRY_TIME_SECONDS
value: "15"
value: "60"
- name: EXECUTIONTYPE
value: Workflow
- name: DB_DRIVER_NAME
Expand Down

0 comments on commit 8469ebf

Please sign in to comment.