Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-default SAs to MariaDB and Minio #245

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add non-default SAs to MariaDB and Minio #245

merged 1 commit into from
Aug 3, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Aug 2, 2023

The issue resolved by this Pull Request:

Resolves #204

Description of your changes:

Testing instructions

Deploy DSPO and DSPA.
Port forward to the mariaDB port:

POD_NAME=$(oc get pods -l app=mariadb-sample -o=jsonpath='{.items[0].metadata.name}')
(base) 
oc port-forward ${POD_NAME} 3306:3306

Connect to the port, login inyo mysql

mysql -h 127.0.0.1 -P 3306 -u root

login into MariaDB

mariadb-install-db --user=mysql

Make sure you're able to connect successfully.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@DharmitD DharmitD added the qe/verify Labels to inform qe on issues to verify. label Aug 2, 2023
@HumairAK
Copy link
Contributor

HumairAK commented Aug 2, 2023

you created the SA's but you didn't assign the deployment to the SA, you do this in the minio/mariadb respective deployment resources, without this it will still use the default SA

@DharmitD
Copy link
Member Author

DharmitD commented Aug 3, 2023

you created the SA's but you didn't assign the deployment to the SA, you do this in the minio/mariadb respective deployment resources, without this it will still use the default SA

My bad, I missed out on pushing the deployment changes earlier. Updated the PR now to have the deployment changes, and tested to make sure deployments use these SAs.

@shalberd
Copy link
Contributor

shalberd commented Aug 3, 2023

does the non-default (by name) serviceaccount have any special RBAC, similar to i.e. odh-dashboard?

controllers/database.go Outdated Show resolved Hide resolved
@DharmitD
Copy link
Member Author

DharmitD commented Aug 3, 2023

does the non-default (by name) serviceaccount have any special RBAC, similar to i.e. odh-dashboard?

No, the non-default (by name) serviceaccount is not intended to have any special RBAC.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 3, 2023
@openshift-ci openshift-ci bot removed the lgtm label Aug 3, 2023
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-245

@HumairAK
Copy link
Contributor

HumairAK commented Aug 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 8651473 into opendatahub-io:main Aug 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm qe/verify Labels to inform qe on issues to verify.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MariaDB should use non-default SA
6 participants