-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-default SAs to MariaDB and Minio #245
Conversation
you created the SA's but you didn't assign the deployment to the SA, you do this in the minio/mariadb respective deployment resources, without this it will still use the default SA |
My bad, I missed out on pushing the deployment changes earlier. Updated the PR now to have the deployment changes, and tested to make sure deployments use these SAs. |
does the non-default (by name) serviceaccount have any special RBAC, similar to i.e. odh-dashboard? |
No, the non-default (by name) serviceaccount is not intended to have any special RBAC. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gmfrasca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A new image has been built to help with testing out this PR: |
/lgtm |
The issue resolved by this Pull Request:
Resolves #204
Description of your changes:
Testing instructions
Deploy DSPO and DSPA.
Port forward to the mariaDB port:
Connect to the port, login inyo mysql
login into MariaDB
Make sure you're able to connect successfully.
Checklist