Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GH workflow repo name and updating input descriptions #261

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fixing GH workflow repo name and updating input descriptions #261

merged 1 commit into from
Aug 9, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Aug 8, 2023

The issue resolved by this Pull Request:

Resolves #178

Description of your changes:

  • Updated input descriptions to add examples
  • Updated branch and tag fields to use input variables
  • Updated repository to create the PR to be opendatahub/odh-manifests

Testing instructions

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-261

@DharmitD DharmitD changed the title Fixing GH workflow repo name and updating input tag descriptions WIP: Fixing GH workflow repo name and updating input tag descriptions Aug 8, 2023
@DharmitD DharmitD changed the title WIP: Fixing GH workflow repo name and updating input tag descriptions WIP: Fixing GH workflow repo name and updating input descriptions Aug 8, 2023
@DharmitD DharmitD changed the title WIP: Fixing GH workflow repo name and updating input descriptions Fixing GH workflow repo name and updating input descriptions Aug 8, 2023
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-261

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-261

@rimolive
Copy link
Contributor

rimolive commented Aug 9, 2023

/lgtm

@amadhusu
Copy link
Contributor

amadhusu commented Aug 9, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amadhusu
Once this PR has been reviewed and has the lgtm label, please ask for approval from rimolive. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DharmitD DharmitD merged commit 5d453f6 into opendatahub-io:main Aug 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated PRs to odh-manifest
4 participants