Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt out as reviewers for data-science-pipeline-operator #397

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

harshad16
Copy link
Member

Opt out as reviewers for data-science-pipeline-operator

The issue resolved by this Pull Request:

Resolves #<issue_number>

Not sure, if this is mandatory.

Description of your changes:

As my focus has shifted a bit, I haven't been able to provide total support in reviewing the PRs.
I want to opt-out as a reviewer for now and continue acting as a contributor going forward.

Thank you to the team.

Testing instructions

NA

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gregsheremeta
Copy link
Contributor

TIL emeritus_approvers is a thing
https://www.kubernetes.dev/docs/guide/owners/#owners-spec

/approve

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HumairAK,gregsheremeta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 411553d into opendatahub-io:main Oct 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants