Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating v2 manifests to utilize DSPO namePrefix #405

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Updating v2 manifests to utilize DSPO namePrefix #405

merged 1 commit into from
Oct 19, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Oct 18, 2023

The issue resolved by this Pull Request:

Resolves #378

Description of your changes:

Updated names of v2 manifests to remove mentions of Kfp, and utlize the data-science-pipelines-operator- namePrefix.
Updated serviceAccountname to serviceAccountName based on an error prompting to do so, while deploying v2.

Testing instructions

deployed a v2 instance using make v2deploy to make sure all resources came up with the data-science-pipelines-operator- prefix correctly.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-405
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/405/head
git checkout -b pullrequest 1e26fd0c29a73025b39ae361742dd42d59c6fce6
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-405"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Oct 19, 2023
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-405

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-405

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit e09a802 into opendatahub-io:dspv2 Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants