Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stable to v2.5.0 #693

Merged
merged 31 commits into from
Aug 19, 2024
Merged

Update stable to v2.5.0 #693

merged 31 commits into from
Aug 19, 2024

Conversation

HumairAK
Copy link
Contributor

diegolovison and others added 30 commits July 19, 2024 00:32
Move embedded binary and bash calls from YAML to a single script
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Consolidate kustomize binaries in DSPO Makefile
Allow the user to fully replace the `data` contents of the kfp-launcher ConfigMap.
The `kfp-launcher` component requires a ConfigMap to exist in the namespace
where it runs (i.e. the namespace where pipelines run). This ConfigMap contains
object storage configuration, as well as pipeline root (object store root path
where artifacts will be uploaded) configuration. Currently this ConfigMap *must*
be named "kfp-launcher". We currently deploy a default copy of the kfp-launcher
ConfigMap via DSPO, but a user may want to provide their own ConfigMap configuration,
so that they can specify multiple object storage sources and paths.

Add a `CustomKfpLauncherConfigMap` parameter to DSPA.ApiServer. When specified,
the `data` contents of the `kfp-launcher` ConfigMap that DSPO writes will be fully
replaced with the `data` contents of the ConfigMap specified here.

Fixes: https://issues.redhat.com/browse/RHOAIENG-4528

Co-authored-by: Achyut Madhusudan <amadhusu@redhat.com>
…deleted

Co-authored-by: Greg Sheremeta <gshereme@redhat.com>
…p-launcher-configmap-contents

add ability to customize `kfp-launcher` ConfigMap data contents
…e-was-not-found-Debug

Clarify the "DSPA not found" log message that happens when a DSPA is deleted
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Expose API Server and Envoy endpoints and add a new Envoy condition
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: vmudadla <vmudadla@redhat.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Copy link
Contributor

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 7304c92 into opendatahub-io:stable Aug 19, 2024
4 of 5 checks passed
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-693
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/693/head
git checkout -b pullrequest 4fbde7a867e1e1676dfc7719e4712435dc531538
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-693"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants