-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch dspa resource not found err to debug #727
switch dspa resource not found err to debug #727
Conversation
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/727/head
git checkout -b pullrequest 77421e93583b55e64cdcfbcb88b3931258645eed
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-727" More instructions here on how to deploy and test a Data Science Pipelines Application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, DharmitD, franciscojavierarceo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will now follow the debug log level when set via zap logging options
this will avoid the spam of:
log messages in the info level here https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/config/base/params.env#L22
and as described here