Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to resolve security scans #79

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Update dependencies to resolve security scans #79

merged 1 commit into from
Sep 8, 2023

Conversation

Xaenalt
Copy link
Member

@Xaenalt Xaenalt commented Sep 5, 2023

Dependency update to address security scans

Need to make sure bumping Ray version here is fine, should be fine if tests pass
Changed over the storage-initializer to use UBI-based images. Need to make sure tests pass with it

@openshift-ci openshift-ci bot added the approved label Sep 5, 2023
@Xaenalt
Copy link
Member Author

Xaenalt commented Sep 5, 2023

Testing instructions should just be does this storage-initializer work, which I think the tests will cover

@israel-hdez
Copy link

Need to figure out how to make E2Es more stable.
Retesting, although I think this PR should go against release-v0.11 branch.

/test e2e-slow e2e-fast

@Xaenalt
Copy link
Member Author

Xaenalt commented Sep 5, 2023

/test e2e-slow e2e-fast

@Xaenalt Xaenalt changed the base branch from master to release-v0.11 September 5, 2023 22:32
@Xaenalt Xaenalt changed the base branch from release-v0.11 to master September 5, 2023 22:32
@Xaenalt Xaenalt changed the base branch from master to release-v0.11 September 5, 2023 22:34
@Xaenalt
Copy link
Member Author

Xaenalt commented Sep 6, 2023

/retest

1 similar comment
@Xaenalt
Copy link
Member Author

Xaenalt commented Sep 6, 2023

/retest

@israel-hdez
Copy link

Forcing to 🟢 CI jobs with known issues

/override ci/prow/pr-image-mirror-kserve-agent ci/prow/pr-image-mirror-kserve-controller ci/prow/pr-image-mirror-kserve-router ci/prow/pr-image-mirror-kserve-storage-initializer

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

@israel-hdez: Overrode contexts on behalf of israel-hdez: ci/prow/pr-image-mirror-kserve-agent, ci/prow/pr-image-mirror-kserve-controller, ci/prow/pr-image-mirror-kserve-router, ci/prow/pr-image-mirror-kserve-storage-initializer

In response to this:

Forcing to 🟢 CI jobs with known issues

/override ci/prow/pr-image-mirror-kserve-agent ci/prow/pr-image-mirror-kserve-controller ci/prow/pr-image-mirror-kserve-router ci/prow/pr-image-mirror-kserve-storage-initializer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@israel-hdez israel-hdez closed this Sep 6, 2023
@israel-hdez
Copy link

Cycle PR to force GHActions to run.

/reopen

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

@israel-hdez: Reopened this PR.

In response to this:

Cycle PR to force GHActions to run.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot reopened this Sep 6, 2023
israel-hdez
israel-hdez approved these changes Sep 6, 2023
View reviewed changes
Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to let auto merge as soon as CI passes

@openshift-ci openshift-ci bot added the lgtm label Sep 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Xaenalt,israel-hdez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link

/retest

@israel-hdez
Copy link

/test e2e-fast

1 similar comment
@Xaenalt
Copy link
Member Author

Xaenalt commented Sep 6, 2023

/test e2e-fast

@heyselbi heyselbi linked an issue Sep 7, 2023 that may be closed by this pull request
Address "High" vulnerabilities in SNYK scans of KServe #73
Closed
@Xaenalt
Copy link
Member Author

Xaenalt commented Sep 8, 2023

Since we're not using 3.11, and it looks like the test failure is independent, going to merge so we have security scans resolved

@Xaenalt Xaenalt merged commit 523be1a into opendatahub-io:release-v0.11 Sep 8, 2023
18 of 19 checks passed
Jooho pushed a commit to Jooho/kserve that referenced this pull request Jan 11, 2024
@openshift-merge-robot
Merge pull request opendatahub-io#79 from dagrayvid/perf-tuning-docs
819a27d 
Add initial performance tuning docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@israel-hdez israel-hdez israel-hdez approved these changes

@heyselbi heyselbi Awaiting requested review from heyselbi

Assignees

@israel-hdez israel-hdez

Labels
approved lgtm
Projects
ODH Model Serving Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address "High" vulnerabilities in SNYK scans of KServe
2 participants
@Xaenalt @israel-hdez