Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates for code synchronization #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

israel-hdez
Copy link

What this PR does / why we need it:

The issue template covers both synchronization with upstream repositories, and also manifest replication to odh-manifest repository.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to opendatahub-io/modelmesh-serving#188

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The issue template covers both synchronization with upstream
repositories, and also manifest replication to `odh-manifest`
repository.
@spolti
Copy link
Member

spolti commented Dec 29, 2023

@israel-hdez does it still valid?

@israel-hdez
Copy link
Author

@spolti I know @heyselbi has a document that may cover this. I'll defer to her the decision to either merge or close.

@spolti
Copy link
Member

spolti commented Jan 9, 2024

Apparently the change looks good, however, wouldn't be better to use the README or another .md file instead a template?

@israel-hdez
Copy link
Author

israel-hdez commented Jan 9, 2024

Apparently the change looks good, however, wouldn't be better to use the README or another .md file instead a template?

Hmm... So, this PR has been here for some time.
My intention was to let people create a GitHub issue from the template and add that ticket to the board for work tracking. Then, people would tick the checkboxes in the ticket as progress is done.

But now that we moved back to Jira, an issue template no longer makes sense. So, you are right.

Well... @spolti you already have done a few code syncs. I think if you find the content useful, I can rework the PR to be a simple md file. Else, if you think the content is no longer relevant, let's simply close.

@spolti
Copy link
Member

spolti commented Jan 24, 2024

@israel-hdez I think we can keep it, it is useful for new contributors.

@spolti
Copy link
Member

spolti commented Jan 24, 2024

/retest

@spolti
Copy link
Member

spolti commented Jun 13, 2024

not related: Error: failed to create iam: LimitExceeded: Cannot exceed quota for OpenIdConnectProvidersPerAccount: 100

/retest

@israel-hdez
Copy link
Author

Now that it passed, I see this is an issue template.
Like a previous PR in another repo, I think we should convert this to a md file under docs, in case it is still worth to have.

@spolti
Copy link
Member

spolti commented Jun 19, 2024

Like a previous PR in another repo, I think we should convert this to a md file under docs, in case it is still worth to have.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: New/Backlog
Development

Successfully merging this pull request may close these issues.

2 participants