Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from kserve:master #88

Merged
merged 43 commits into from
Nov 24, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 21, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

sivanantha321 and others added 3 commits September 13, 2023 05:41
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* Fixed torchserve e2e test.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Upgraded torchserve-kfs image to 0.8.2

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Fixed torchserve transformer e2e.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Set PROTOCOL_VERSION env based on protocol version spec.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

---------

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
* Refactoring common code to a function

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Added e2e test cases for splitter nodes

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Fixed linting errors

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Minor refactoring for error message

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

---------

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@israel-hdez
Copy link

/ok-to-test

@israel-hdez
Copy link

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, pull[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link

/override "Red Hat Trusted App Pipeline"

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@israel-hdez: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Trusted App Pipeline

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-fast
  • ci/prow/e2e-slow
  • ci/prow/images
  • ci/prow/pr-image-mirror-kserve-agent
  • ci/prow/pr-image-mirror-kserve-controller
  • ci/prow/pr-image-mirror-kserve-router
  • ci/prow/pr-image-mirror-kserve-storage-initializer
  • pull-ci-opendatahub-io-kserve-master-e2e-fast
  • pull-ci-opendatahub-io-kserve-master-e2e-slow
  • pull-ci-opendatahub-io-kserve-master-images
  • pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-agent
  • pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-controller
  • pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-router
  • pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-storage-initializer
  • push
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Trusted App Pipeline"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anishasthana
Copy link
Member

/ok-to-test

* Move storage uri check from validator to pod mutator

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Move storage uri validation to controller

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix test

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix tests, add comments, and remove model transition status

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

---------

Signed-off-by: Jin Dong <jdong183@bloomberg.net>
@openshift-ci openshift-ci bot removed the lgtm label Sep 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

New changes are detected. LGTM label has been removed.

rachitchauhan43 and others added 2 commits September 22, 2023 15:46
* Bumping version for 0.11.1

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* add back kustomize

* Update VERSION

---------

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Make storage initializer crd configurable

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@heyselbi heyselbi linked an issue Sep 26, 2023 that may be closed by this pull request
@israel-hdez israel-hdez reopened this Sep 27, 2023
ckadner and others added 2 commits September 30, 2023 11:25
* Update feature_request.md

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Rewording

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

---------

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* CVE-2023-44487

core: Core dependencies update: x/net and grpc

Signed-off-by: Spolti <fspolti@redhat.com>

* Update agent.Dockerfile

Signed-off-by: Filippe Spolti <filippespolti@gmail.com>

---------

Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Filippe Spolti <filippespolti@gmail.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* cmd/agent/main.go
  * Static code analysis states that unsanitized usage of the
    `--component-port` flag can potentially lead to SSRF. In
    practice, this may be very hard to happen, given that the source of
    the flag is always an integer (taken from `containerPort` of a Pod).
    Anyways, this is switching that flag to an Integer to be on the safe
    side (and to prevent the warning from the static code analysis tool).

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

… runtime (#3181)

Validation added for ensuring same model format has same priority for runtime.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HAO2167 and others added 2 commits November 18, 2023 16:19
… request (#3079)

* Update main.go

Signed-off-by: HAO2167 <49943173+HAO2167@users.noreply.github.com>

* add test case

Signed-off-by: HAO <howard31124@gmail.com>

* add test case v2

Signed-off-by: HAO <howard31124@gmail.com>

---------

Signed-off-by: HAO2167 <49943173+HAO2167@users.noreply.github.com>
Signed-off-by: HAO <howard31124@gmail.com>
Signed-off-by: homily707 <homily707@outlook.com>
Co-authored-by: homily707 <lmh@tensorstack.com>
)

support verify variable with storage-config json style (fix-3263)

Signed-off-by: jooho <jlee@redhat.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit bb3615b into opendatahub-io:master Nov 24, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[RECURRENT] KServe master branch sync