Skip to content

Commit

Permalink
NO-JIRA: fix(gha) improve robustness by checking for resource existence
Browse files Browse the repository at this point in the history
Without this, the gha is flaky and may fail with

```
notebook.kubeflow.org/minimal-notebook created
Error from server (NotFound): statefulsets.apps "minimal-notebook" not found
```
  • Loading branch information
jiridanek committed Oct 16, 2024
1 parent 385767d commit ed317a7
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ jobs:
port: notebook-port
EOF
# wait for the statefulset to be created
timeout 100 bash -c -- 'until kubectl get statefulset minimal-notebook; do sleep 1; done'
# wait for the good result
kubectl rollout status --watch statefulset minimal-notebook
kubectl wait statefulset minimal-notebook --for=jsonpath='{.spec.replicas}'=1 --timeout=100s
Expand Down

0 comments on commit ed317a7

Please sign in to comment.