Logout in Jupyter is not working if you logged out from OpenShift

[harshad16]

/kind bug

What steps did you take and what happened:
Scenario

-> open RHODS using the URL
-> login
-> open Jupyter Notebook using the URL
-> login
-> logout from JupyterLab
-> The logout will work because you are logged in OpenShift

Clear all browser cookies and data

-> open Jupyter Notebook using the URL
-> login
-> logout from JupyterLab
-> close the browser
-> open Jupyter Notebook using the URL
-> it is working

What did you expect to happen:

Log out properly.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Check oauth-proxy logout

Environment:

• Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard):
• kfctl version: (use kfctl version):
• Kubernetes platform: (e.g. minikube)
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

JIRA: https://issues.redhat.com/browse/RHODS-10932

Acceptance criteria

• Re-adjust logout URL to ouath proxy setting and then redirect.
  

  kubeflow/components/odh-notebook-controller/controllers/notebook_webhook.go

  Line 156 in de72e7f

  "--logout-url="+notebook.ObjectMeta.Annotations[AnnotationLogoutUrl])

• Explore additional way via oauth-proxy.
  https://github.com/openshift/oauth-proxy

[jbyrne-redhat]

@harshad16 Does this release note text sound OK?

Logging out of JupyterLab does not work if you are already logged out of OpenShift

If you log out of OpenShift before you log out of JupyterLab, then logging out of JupyterLab is not successful. For example, if you know the URL for a Jupyter notebook, you are able to open this again in your browser.

Workaround
Log out of JupyterLab before you log out of OpenShift.

[harshad16]

@jbyrne-redhat , we can make it more focused and mention it like this:

Logging out of JupyterLab does not work if you are already logged out of OpenShift Data Science Dashboard

If you log out of the OpenShift Data Science Dashboard before you log out of JupyterLab, then logging out of JupyterLab is not successful. For example, if you know the URL for a Jupyter Notebook, you are able to open this again in your browser.

Workaround
Log out of JupyterLab before you log out of OpenShift Data Science Dashboard.

[jbyrne-redhat]

@jbyrne-redhat , we can make it more focused and mention it like this:

Logging out of JupyterLab does not work if you are already logged out of OpenShift Data Science Dashboard

If you log out of the OpenShift Data Science Dashboard before you log out of JupyterLab, then logging out of JupyterLab is not successful. For example, if you know the URL for a Jupyter Notebook, you are able to open this again in your browser.

Workaround Log out of JupyterLab before you log out of OpenShift Data Science Dashboard.

Done @harshad16 - thanks.

[rkpattnaik780]

When user logs out from JupyterLab, we get a 403 when trying to hit the /logout endpoint. We might need to investigate further about the handler for /logout endpoint and might need to allow requests without authorization.