Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update manifest to support generic route #949

Conversation

vaibhavjainwiz
Copy link
Member

Description

With opendatahub-io/odh-model-controller#59 we had implemented a hot fix by exposing predictor URL directly to user but to provide proper fix we need to implement a generic openshift route for kserve inference service.

Now with opendatahub-io/odh-model-controller#84 we had implemented the generic route functionality so I am resetting the disableIstioVirtualHost: false

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Vaibhav Jain <vajain@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho
Copy link
Contributor

Jooho commented Oct 12, 2023

looks role.yaml format has changed. is it reformatted by make run fmt by modelmesh-serving ?

Signed-off-by: Vaibhav Jain <vajain@redhat.com>
@vaibhavjainwiz
Copy link
Member Author

looks role.yaml format has changed. is it reformatted by make run fmt by modelmesh-serving ?

I fixed the formatting

@vaibhavjainwiz
Copy link
Member Author

closing it because manifest are now moved inside individual repos.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants