Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CODEOWNERS file to get auto review requests #101

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

lydiascarf
Copy link
Collaborator

Adds Bryan and I as CODEOWNERS, to be automatically requested on new PRs. See here for what it'll look like if you open a PR against main after this gets merged. Particularly, you should look at the "Reviewers" section and note who will be requested. I also pushed a test branch here where you can see that @jrmidkiff will be additionally auto requested for changes to the city org.

Open Questions:

  • @BryanQuigley I'd be curious to know if, when you follow the above link, it says that I'll be requested and you won't. I see it as you being requested and me not being requested. I assume that's how it works, but I just want to double check.
  • We don't have a team so we may not be able to do the round robin thing we set up when we were at Azavea. See docs here for that process.
  • Finally, I'm not sure the best way to assign someone from the city as a CODEOWNER on their datasets since those files would have to be matched by filename patterns. Could we put the city datasets in a subdir? I'd rather not enforce a naming scheme, but I think it would be smart to prove out a process for this kind of thing if we are going to pick up more contributors

Copy link
Member

@BryanQuigley BryanQuigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of it works as expected.

I like the idea of a folder for the city of phila datasets - but I haven't looked into implementation details. We don't want any actual paths to change on the site.

@lydiascarf lydiascarf self-assigned this Oct 10, 2023
@lydiascarf lydiascarf merged commit 829da63 into main Oct 10, 2023
14 checks passed
@lydiascarf lydiascarf deleted the codeowners-init branch October 10, 2023 19:05
@lydiascarf lydiascarf linked an issue Oct 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CODEOWNERS file
2 participants