-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main rebase unique branch name 23 10 #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanQuigley
force-pushed
the
main_rebase_unique_branch_name_23_10
branch
from
October 11, 2023 03:55
d258670
to
06694eb
Compare
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.9 to 1.14.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.9...v1.14.3) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.6 to 0.23.9. - [Release notes](https://github.com/gjtorikian/commonmarker/releases) - [Changelog](https://github.com/gjtorikian/commonmarker/blob/main/CHANGELOG.md) - [Commits](gjtorikian/commonmarker@v0.23.6...v0.23.9) --- updated-dependencies: - dependency-name: commonmarker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [activesupport](https://github.com/rails/rails) from 6.0.6 to 6.0.6.1. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4.2/activesupport/CHANGELOG.md) - [Commits](rails/rails@v6.0.6...v6.0.6.1) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Also updated bundler and ruby versions in Docker. Had to go through several iterations to get GitHub-metadata to work, as part of that: * Dropped Open in GitHub button from categories page as we don't generally want edits there. * GitHub edit link didn't work initially so reverted pending fix for jekyll/github-metadata#249.
These were included as part of GH pages in 3.9.
Require yaml parsing for build, builds will fail if yaml isn't correct. switch to faster megalinter which should make it easier to do more future tests included some yaml prettier changes Resolves: #276
Aside from letting us drop the legacy build it also let's us drop the jquery-deparam dependency replacing with built-in urlSearchParams
Works around jekyll/github-metadata#249 Only kept Edit on Github link for datasets as the others will not be as common. Moved Open in Github link so it's clearly more related to the dataset instead of the org sidebar. Resolves: #31, #37
Don't check python files Fix line in yml and bump ruby action
BryanQuigley
force-pushed
the
main_rebase_unique_branch_name_23_10
branch
from
October 11, 2023 03:56
06694eb
to
f676c1b
Compare
Ready for review - synced with upstream |
lydiascarf
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! runs alright too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #105