Run conan install in parallel #363
Conversation
…in action. Required for gradle's configuration-cache
|
Build failure, lol |
|
Conan install doesn't like being called in parallel with an empty conan cache. Made sure to call conan install armv8 before calling conan install on all the other arches. Should be good now |
There was a problem hiding this comment.
Nice idea! Works for me locally, so good to go in my opinion. @andiwand thoughts?
Crazy idea: is it possible to turn that into a separate plugin that other projects could make use of without much setup? That would be a nice project for the opendocument-organization!
|
Yes. ConanAndroid Gradle plugin would be way cooler than just keeping this class in build.gradle of all our projects. I should look into it |
| "-s", "odrcore/*:build_type=RelWithDebInfo", | ||
| ) | ||
| } | ||
| ["armv8", "armv7", "x86", "x86_64"].each { architecture -> |
There was a problem hiding this comment.
should we put this in a list somewhere?
There was a problem hiding this comment.
Architecture list? Well, it is going to change sometime in the future, once we drop armv7 support, but I doubt that's anytime soon
There was a problem hiding this comment.
I just saw that we have the same list twice so we might put this in a variable or somewhere. But nothing crucial
There was a problem hiding this comment.
True, arches are defined in two places. However, once our plugin is published, most of this will be removed, so I'll just keep this as is and merge, because we don't know how soon it will be published
I've changed the conan install task.
Moved it into a Java Task class with inputs and output, so it could be reused for different architectures.
Having separate instances of conan install tasks for each architecture allows running them in parallel.
Did a bit of benchmarking, without this PR
./gradlew clean; time ./gradlew assembleDebugusually takes 30s for me, best case I ever saw was 23s. With this PR, the same build for me takes 20 to 15s, sometimes as low as 10s.These numbers are with all conan packages available in cache or artifactory. In cases where conan packages are actually being build from source, this PR would give even more speed-up, since a lot of time is spent on single threaded CMake execution.
Enabling parallel execution requires enabling gradle's configuration-cache. It should work without errors, but if we do get errors, we can always disable it in gradle.properties and return to regular serial task execution.
Gradle's configuration-cache requires that tasks don't reference project variables, so I've had to update conanProfile and .cxx cleaner task. Also, upgraded Gradle wrapper to 8.9, for good measure, since this is very related.