Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(backup-restore): update kubectl output #585

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Cogitri
Copy link

@Cogitri Cogitri commented Sep 11, 2024

Was a bit confused at first why the restic pods don't show up - but I believe the docs are just outdated, the newer Velero versions don't seem to have separate restic pods anymore.

I'm actually not sure if restic is actually required though - doesn't the openebs Velero plugin handle sending the ZFS snapshots, thereby not ever using restic?

Pull Request template

Why is this PR required? What issue does it fix?:

  • Updates the docs

What this PR does?:

  • Velero doesn't start the Restic Pods anymore.
  • Also update the AWS-Plugin.

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/website is used to track them:

@Cogitri
Copy link
Author

Cogitri commented Sep 11, 2024

Also, just to make sure I'm understading the docs correctly - since restic isn't used, there's currently no way to do encrypted backups?

@sinhaashish
Copy link
Member

sinhaashish commented Sep 17, 2024

I suggest to remove the uploader-type as kopia is default being used in velero

For backup, the path is specified at the installation time through the uploader-type flag, the valid value is either restic or kopia, or default to kopia if the value is not specified. The selection is not allowed to be changed after the installation.

Link https://velero.io/docs/main/file-system-backup/#how-velero-integrates-with-restic

Moreover please sign your commit

@Cogitri
Copy link
Author

Cogitri commented Sep 25, 2024

I don't think FSB is used by ZFS-LocalPV either way, so I've gone ahead and removed the uploader type as suggested.

* Velero doesn't start the Restic Pods anymore.
* Also update the AWS-Plugin.

Signed-off-by: Rasmus Thomsen <oss@cogitri.dev>
@Abhinandan-Purkait
Copy link
Member

@sinhaashish Can this be merged now or does it need more changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants