refactor: after review

openedx · May 15, 2023 · 597bb37 · 597bb37
1 parent 9895081
commit 597bb37
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 14 deletions.
diff --git a/src/DataTable/CardView.d.ts b/src/DataTable/CardView.d.ts
@@ -15,7 +15,7 @@ export interface CardViewProps {
     skeletonCardCount?: number;
 }
 
-declare function CardView<T>(props: CardViewProps): JSX.Element;
+declare function CardView(props: CardViewProps): JSX.Element;
 
 export default CardView;
 
diff --git a/src/DataTable/TableRow.d.ts b/src/DataTable/TableRow.d.ts
@@ -8,6 +8,6 @@ export interface TableRowProps {
     };
 }
 
-declare function TableRow({ row }: TableRowProps): JSX.Element;
+declare function TableRow(props: TableRowProps): JSX.Element;
 
 export default TableRow;
diff --git a/src/DataTable/index.d.ts b/src/DataTable/index.d.ts
@@ -82,7 +82,7 @@ export interface DataTableProps {
     manualSortBy?: boolean;
     isExpandable?: boolean;
     renderRowSubComponent?: (row: number, index: number) => React.ReactNode;
-    bulkActions?: BulkActionProp[] | (() => BulkActionProp[]) | React.ReactElement;
+    bulkActions?: BulkActionProp[];
     tableActions?: TableActionType[];
     numBreakoutFilters?: 1 | 2 | 3 | 4;
     initialTableOptions?: object;

diff --git a/src/Dropzone/index.d.ts b/src/Dropzone/index.d.ts
@@ -5,8 +5,8 @@ export interface DropzoneProps {
     accept?: { [key: string]: string[] };
     maxSize?: number;
     minSize?: number;
-    onUploadProgress?: (percentageUploaded: number, progressEvent: ProgressEvent) => void;
-    onUploadCancel?: (response: Response) => void;
+    onUploadProgress?: (percentageUploaded: number, progressEvent: AbortSignal) => void;
+    onUploadCancel?: () => void;
     onProcessUpload: (params: {
         fileData: object;
         requestConfig: object;

diff --git a/src/Form/FormRadioSetContext.d.ts b/src/Form/FormRadioSetContext.d.ts
@@ -16,7 +16,7 @@ export interface FormRadioSetContextValue extends RadioControlProps {
     getRadioControlProps: (props: RadioControlProps) => RadioControlProps;
 }
 
-export interface FormRadioSetContextProviderProps extends Omit<FormRadioSetContextValue, 'getRadioControlProps'>  {
+export interface FormRadioSetContextProviderProps extends FormRadioSetContextValue {
     children: React.ReactNode;
 }
 

diff --git a/src/Icon/index.d.ts b/src/Icon/index.d.ts
@@ -10,7 +10,7 @@ export interface IconProps {
   size?: 'xs' | 'sm' | 'md' | 'lg';
   className?: string;
   hidden?: boolean;
-  screenReaderText?: string | React.ReactNode;
+  screenReaderText?: React.ReactNode;
 }
 
 declare const Icon: React.FC<IconProps>;

diff --git a/src/IconButtonToggle/index.d.ts b/src/IconButtonToggle/index.d.ts
@@ -4,7 +4,7 @@ import { IconButtonProps } from '../IconButton';
 export interface IconButtonToggleProps {
     activeValue?: string;
     onChange?: (value: string) => void;
-    children: React.ReactElement<IconButtonProps>[];
+    children: React.ReactElement<IconButtonProps>;
 }
 
 declare const IconButtonToggle: React.FC<IconButtonToggleProps>;

diff --git a/src/Modal/ModalLayer.d.ts b/src/Modal/ModalLayer.d.ts
@@ -8,8 +8,8 @@ export interface ModalLayerProps {
     zIndex?: number;
 }
 
-export function ModalBackdrop({ onClick }: { onClick?: () => void }): JSX.Element;
+export function ModalBackdrop(props: { onClick?: () => void }): JSX.Element;
 
-export function ModalContentContainer({ children }: { children?: React.ReactNode }): JSX.Element;
+export function ModalContentContainer(props: { children?: React.ReactNode }): JSX.Element;
 
 export default function ModalLayer(props: ModalLayerProps): JSX.Element;
diff --git a/src/Overlay/index.d.ts b/src/Overlay/index.d.ts
@@ -7,7 +7,7 @@ export interface OverlayProps extends React.HTMLAttributes<HTMLDivElement> {
     show: boolean;
     onHide: () => void;
     placement?: Placement;
-    container?: Element | (() => Element | null) | null;
+    container?: React.ReactElement | (() => React.ReactElement | null) | null;
     flip?: boolean;
     popperConfig?: Object;
     rootClose?: boolean;

diff --git a/src/hooks/useIndexOfLastVisibleChild.d.ts b/src/hooks/useIndexOfLastVisibleChild.d.ts
@@ -3,6 +3,6 @@ import React from 'react';
 declare const useIndexOfLastVisibleChild: (
     containerElementRef: React.RefObject<Element>,
     overflowElementRef?: React.RefObject<Element>
-) => number[];
+) => number;
 
 export default useIndexOfLastVisibleChild;
diff --git a/src/hooks/useWindowSize.d.ts b/src/hooks/useWindowSize.d.ts
@@ -1,6 +1,6 @@
 export interface WindowSizeTypes {
-    width: number | undefined;
-    height: number | undefined;
+    width?: number;
+    height?: number;
 }
 
 declare function useWindowSize(): WindowSizeTypes;