[BD-46] fix: fixed border-radius of the card img

[PKulkoRaccoonGang]

Description

Fixed border-radius of the Card img

Issue: #2498

Deploy Preview

Card component

Merge Checklist

• If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
• Does your change adhere to the documented style conventions?
• Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
• Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
• Were your changes tested in the example app?
• Is there adequate test coverage for your changes?
• Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

• Verify your changes were released to NPM at the expected version.
• If you'd like, share your contribution in #show-and-tell.
• 🎉 🙌 Celebrate! Thanks for your contribution.

[openedx-webhooks]

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

[netlify]

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	954063f
🔍 Latest deploy log	https://app.netlify.com/sites/paragon-openedx/deploys/64d374ecd3648600081adc7f
😎 Deploy Preview	https://deploy-preview-2511--paragon-openedx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (0902f62) 91.65% compared to head (954063f) 91.65%.
Report is 5 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2511   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         236      236           
  Lines        4195     4195           
  Branches     1012     1012           
=======================================
  Hits         3845     3845           
  Misses        346      346           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[monteri]

@adamstankiewicz I have checked orientation='horizontal' + isLoading and it seems Skeleton is invisible for Card.Header and Card.Status. Also I think that it is good idea to implement isLoading for Card.Body too.

[brian-smith-tcril]

@adamstankiewicz was the intention of this comment to handle things this way, or to just use $card-border-radius everywhere directly?

[PKulkoRaccoonGang]

In this PR @adamstankiewicz proposed to unify specific border-radius variables for Card and CardImg.

[adamstankiewicz]

@PKulkoRaccoonGang @brian-smith-tcril I believe it would be preferable to have a single $card-border-radius used everywhere directly. That said, if we remove $card-image-border-radius, any brand authors that might have overridden that variable to customize the brand would no longer be able to. That said, it's probably unlikely many brand authors are modifying this variable 🤷‍♂️

Perhaps we plan to keep it with $card-image-border-radius: $card-border-radius as currently implemented for now and then remove it fully (in favor of using $card-border-radius everywhere directly) in the alpha breaking release?

[adamstankiewicz]

LGTM!

[openedx-webhooks]

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-semantic-release]

🎉 This PR is included in version 20.46.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀