fix: filtered dropdown items by display value instead of event target #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cintnguyen
force-pushed
the
cindy/form-autoSuggest-keyboard-dropdown-behavior
branch
from
28d5ea7
to
8faa847
Compare
cintnguyen
commented
Aug 15, 2023
| @@ -140,7 +140,7 @@ describe('FormAutosuggest', () => { | |||
| expect(container.find(dropdownContainer).find('button').length).toEqual(0); | |||
|
|
|||
| container.find('button.pgn__form-autosuggest__icon-button').simulate('click'); | |||
| expect(container.find(dropdownContainer).find('button').length).toEqual(3); | |||
| expect(container.find(dropdownContainer).find('button').length).toEqual(1); | |||
There was a problem hiding this comment.
Previous behavior was not filtering the options when toggling via the dropdown buttons. This test was verifying that behavior. Now toggling does not change what has been filtered from the dropdown.
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
cintnguyen
force-pushed
the
cindy/form-autoSuggest-keyboard-dropdown-behavior
branch
from
8faa847
to
4a7ae9a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2547 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 236 236
Lines 4195 4195
Branches 1012 1012
=======================================
Hits 3845 3845
Misses 346 346
Partials 4 4
☔ View full report in Codecov by Sentry. |
adamstankiewicz
approved these changes
Aug 16, 2023
brian-smith-tcril
approved these changes
Aug 16, 2023
|
🎉 This PR is included in version 21.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viktorrusakov
pushed a commit
that referenced
this pull request
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2535
Deploy Preview
https://deploy-preview-2547--paragon-openedx.netlify.app/components/form/form-autosuggest/
Merge Checklist
wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist