-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updating to Style Dictionary v4 #3186
Open
PKulkoRaccoonGang
wants to merge
11
commits into
alpha
Choose a base branch
from
Peter_Kulko/style-dictionary-v4
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c4f5466
feat: update style dictionary to v4
PKulkoRaccoonGang 22041ec
feat: converted utils and breakpoints
PKulkoRaccoonGang 9c58f15
feat: DTCG format
PKulkoRaccoonGang f29f538
refactor: added dynamic imports
PKulkoRaccoonGang bb70975
refactor: code refactoring
PKulkoRaccoonGang 0e1ef04
refactor: corrected header
PKulkoRaccoonGang da00992
feat: --output-references CLI arg, registers filters, updates CSS var…
adamstankiewicz 5843459
chore: corrected design tokens types
PKulkoRaccoonGang 1b83468
chore: the fractional value of the spacer has had its comma replaced …
PKulkoRaccoonGang 029325a
refactor: corrected changed values of tokens and CSS variables
PKulkoRaccoonGang a0baaa6
feat: added sd-transforms; refs in source-tokens-only output; fixed r…
adamstankiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
.PHONY: build | ||
build: | ||
rm -rf ./dist | ||
tsc --project tsconfig.build.json | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we might have lost the
transformGroup: 'css'
, which I think we want to keep so it does these default transforms provided bystyle-dictionary
?Looks like adding it back in and running
build-tokens
only results in a diff that adds therem
unit to0
values in a handful of places, e.g.0
->0rem
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[inform] Implemented in follow-up PR: #3219