-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: test built version #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonjourmauko
added
the
kind:build
Changes that affect the build system or external dependencies
label
Oct 16, 2024
6 tasks
bonjourmauko
force-pushed
the
ci/test-built
branch
from
October 16, 2024 13:16
45c3c18
to
4e42cb8
Compare
bonjourmauko
force-pushed
the
ci/test-built
branch
from
October 16, 2024 13:25
38cd143
to
f958e74
Compare
benoit-cty
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work.
Maybe it will be nice to add some installation instructions in the contributing.md :
You need to have tox and Python 3.9 to run test like the CI does :
# Install PyEnv
curl https://pyenv.run | bash
# Install Python 3.9 needed by tox
pyenv install 3.9.20
# Install pipx
sudo apt install pipx
# Install tox
pipx install tox
Run lint with tox -r -e lint
Run test with tox -r -e py39
bonjourmauko
force-pushed
the
ci/test-built
branch
from
October 18, 2024 10:08
4b668a5
to
3430b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of openfisca/openfisca-core#1064
Depends on #156
tox
to test builds in isolation