Skip to content

Commit

Permalink
Do not lint on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
bonjourmauko committed Jan 24, 2023
1 parent ea5a9a5 commit 6f2a60c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
10 changes: 2 additions & 8 deletions .github/workflows/merge.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,14 @@ jobs:
strategy:
fail-fast: true
matrix:
os: [ubuntu-20.04, windows-latest]
numpy: [1.20.3]
python: [3.8.10, 3.7.9] # Patch version must be specified to avoid any cache confusion, since the cache key depends on the full Python version. If left unspecified, different patch versions could be allocated between jobs, and any such difference would lead to a cache not found error.
include:
- os: ubuntu-20.04
activate_command: source venv/bin/activate
- os: windows-latest
activate_command: .\venv\Scripts\activate
uses: ./.github/workflows/_lint.yaml
with:
os: ${{ matrix.os }}
os: ubuntu-20.04
numpy: ${{ matrix.numpy }}
python: ${{ matrix.python }}
activate_command: ${{ matrix.activate_command }}
activate_command: source venv/bin/activate

# The idea behind these dependencies is we want to give feedback to
# contributors on the version number only after they have passed all tests,
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,14 @@ jobs:
strategy:
fail-fast: true
matrix:
os: [ubuntu-20.04, windows-latest]
numpy: [1.20.3]
python: [3.8.10, 3.7.9] # Patch version must be specified to avoid any cache confusion, since the cache key depends on the full Python version. If left unspecified, different patch versions could be allocated between jobs, and any such difference would lead to a cache not found error.
include:
- os: ubuntu-20.04
activate_command: source venv/bin/activate
- os: windows-latest
activate_command: .\venv\Scripts\activate
uses: ./.github/workflows/_lint.yaml
with:
os: ${{ matrix.os }}
os: ubuntu-20.04
numpy: ${{ matrix.numpy }}
python: ${{ matrix.python }}
activate_command: ${{ matrix.activate_command }}
activate_command: source venv/bin/activate

# The idea behind these dependencies is we want to give feedback to
# contributors on the version number only after they have passed all tests,
Expand Down

0 comments on commit 6f2a60c

Please sign in to comment.