Add support for Python 3.8 #1168
Conversation
bonjourmauko
force-pushed
the
test-python-3-matrix
branch
30 times, most recently
from
c368d4a
to
addb116
Compare
bonjourmauko
force-pushed
the
test-python-3-matrix
branch
from
ab7d424
to
51272ee
Compare
|
Hi @MattiSG, please let me know if you're OK with these changes. I removed the web triggered part to reduce scope. |
| on: | ||
| pull_request: | ||
| types: [assigned, opened, reopened, synchronize, ready_for_review] |
There was a problem hiding this comment.
After this PR, the CI will not run on push outside a Pull Request.
Curent behavior is to run on all push : on: [ push, pull_request, workflow_dispatch ].
See also : openfisca/openfisca-france#1788 (comment)
There was a problem hiding this comment.
Yes, I removed it to easy review. But I can readd it. I'll do.
| strategy: | ||
| fail-fast: true | ||
| matrix: | ||
| os: [ubuntu-20.04, windows-latest] |
There was a problem hiding this comment.
Can you add a comment to explain why you use old ubuntu-20.04 instead of ubuntu-22.04 ?
Because the Python version between Windows-latest and Ubuntu 22.04 did not match, cf https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json ?
See my failing test on https://github.com/openfisca/openfisca-core/actions/runs/4015575836
There was a problem hiding this comment.
I think in the time between this PR was open Github also updated windows.
|
Hello @bonjourmauko, are you OK to close this PR as support for Python 3.8 has been dropped ? |
Let me take a look. |
Fixes #1035
Fixes #1153
Fixes #1058
Fixes #1111
Breaking changes
New features