Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc neutralize variable in YAML test #252

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Doc neutralize variable in YAML test #252

wants to merge 2 commits into from

Conversation

benjello
Copy link
Member

@benjello benjello requested a review from HAEKADI August 31, 2021 12:23
@benjello benjello mentioned this pull request Aug 31, 2021
Open
HAEKADI
HAEKADI reviewed Aug 31, 2021
View reviewed changes
Copy link
Contributor

@HAEKADI HAEKADI left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @benjello for the addition 👍

From what I understand the PR is still in the works, shouldn't we wait for it to merge before adding the feature to the doc?

source/coding-the-legislation/writing_yaml_tests.md Outdated Show resolved Hide resolved
@benjello @HAEKADI
Update source/coding-the-legislation/writing_yaml_tests.md
6d0897d 
Co-authored-by: Hajar AIT EL KADI <48837850+HAEKADI@users.noreply.github.com>
@benjello
Copy link
Member Author

Indeed @HAEKADI let's wait for merge on openfisca-core.

@MattiSG MattiSG marked this pull request as draft June 17, 2022 13:05
@MattiSG
Copy link
Member

MattiSG commented Jun 17, 2022

Blocked until openfisca/openfisca-core#1021 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HAEKADI HAEKADI HAEKADI left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjello @MattiSG @HAEKADI