Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve copywriting for Simulation #302

Merged
merged 7 commits into from
May 21, 2024
Merged

Improve copywriting for Simulation #302

merged 7 commits into from
May 21, 2024

Conversation

verbman
Copy link
Contributor

@verbman verbman commented May 14, 2024

Training Review of Documentation, Part Running a simulation
(https://openfisca.org/doc/simulate/index.html)

@verbman verbman requested a review from MattiSG May 14, 2024 09:02
@MattiSG MattiSG changed the title Simulation Improve copywriting for Simulation May 14, 2024
@MattiSG MattiSG requested review from sandcha and removed request for MattiSG May 14, 2024 15:56
Copy link
Contributor

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @verbman 🙌
I'm not requesting changes here but you will find comments on 2 minor typos and minor additional suggestions.

source/openfisca-web-api/trace-simulation.md Show resolved Hide resolved
source/simulate/analyse-simulation.md Outdated Show resolved Hide resolved
source/simulate/analyse-simulation.md Show resolved Hide resolved
source/simulate/analyse-simulation.md Outdated Show resolved Hide resolved
source/simulate/analyse-simulation.md Outdated Show resolved Hide resolved
source/simulate/replicate-simulation-inputs.md Outdated Show resolved Hide resolved
source/simulate/replicate-simulation-inputs.md Outdated Show resolved Hide resolved

This allows us to use OpenFisca for `multivariate observation`: charting how two variables interact to control a third, as in [this example](https://mybinder.org/v2/gh/adrienpacifico/adrienpacifico.github.io/master?filepath=Notebooks/plotly_openfisca_cohabitants.ipynb).
This allows OpenFisca to be used for `multivariate observation`: charting how two variables interact to control a third, as in [this example](https://mybinder.org/v2/gh/adrienpacifico/adrienpacifico.github.io/master?filepath=Notebooks/plotly_openfisca_cohabitants.ipynb).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is off topic in this PR but we have an issue with the notebook here. cc @benjello

source/simulate/run-simulation.md Show resolved Hide resolved
source/simulate/run-simulation.md Outdated Show resolved Hide resolved
@verbman verbman requested review from sandcha and MattiSG May 20, 2024 09:28
@MattiSG
Copy link
Member

MattiSG commented May 20, 2024

Thanks @verbman and @sandcha for the improvements! I have a bit too much to do and will thus let @sandcha approve this PR after reviewing her requested changes were taken into account 🙂

@MattiSG MattiSG removed their request for review May 20, 2024 09:44
@MattiSG
Copy link
Member

MattiSG commented May 20, 2024

@verbman I see there was no “request changes” though, only comments, so feel free to proceed if confident 🙂

@verbman verbman merged commit 9e508eb into master May 21, 2024
2 checks passed
@verbman verbman deleted the simulation branch May 21, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants