Improve copywriting for Installation #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once you are sure that your suggested diff contains only the updated installation instructions, please request review from @sandcha. |
MattiSG
changed the title
verbman
force-pushed
the
update-default-install
branch
from
b6d9b67
to
fea21b4
Compare
verbman
force-pushed
the
update-default-install
branch
from
fea21b4
to
30d4d2a
Compare
sandcha
approved these changes
May 21, 2024
There was a problem hiding this comment.
Thank you very much for this update 💞
I'm approving the PR; nevertheless you will find some comments and it might still be interesting to include what is said on:
source/installation/access-countrys-source-code.mdto explain that contributors need to install the source code with SSH,source/installation/installation-requirements.mdfor windows users as they can now use pip,source/installation/windows-no-admin.mdbecause the broken link is easy to fix.
MattiSG
reviewed
May 21, 2024
There was a problem hiding this comment.
I don't have time to review the contents and trust that two trusted senior contributors reviewing content that was originally written some time ago by @sandcha but that I had fully reviewed is more than enough! I thus dismiss my request for review and let @verbman include whichever feedback he deems relevant and merge 🎉
This was referenced May 21, 2024
Co-authored-by: sandcha <sandcha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request completes the work done by @sandcha on the Installation (now Getting started) section and incorporates the changes suggested in the now superseded PR 300 which I will close (thank you to those who reviewed that). I have also renamed files and reordered the section. I appreciate this constitutes a larger Pull Request than I might have hoped for.
I believe this should not be merged until #299 has been accepted.