[kermi] improved README.md, corrected bundles for MR

Signed-off-by: Kai Neuhaus <code@kaineuhaus.com> Update bundles/org.openhab.binding.modbus.kermi/src/main/java/org/openhab/binding/modbus/kermi/internal/dto/AlarmDTO.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: KaiNative <github@kaineuhaus.com> Update bundles/org.openhab.binding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-chargingcircuit-channel-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: KaiNative <github@kaineuhaus.com> Update bundles/org.openhab.binding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-chargingcircuit-channel-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: KaiNative <github@kaineuhaus.com> Update bundles/org.openhab.binding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-power-channel-groups.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: KaiNative <github@kaineuhaus.com> Update bundles/org.openhab.binding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-energysource-channel-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: KaiNative <github@kaineuhaus.com> Update bundles/org.openhab.binding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-chargingcircuit-channel-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: KaiNative <github@kaineuhaus.com>
openhab · May 8, 2024 · b6763fd · b6763fd
1 parent 03cf889
commit b6763fd
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 14 deletions.
diff --git a/bundles/org.openhab.binding.modbus.kermi/README.md b/bundles/org.openhab.binding.modbus.kermi/README.md
@@ -97,10 +97,9 @@ They are grouped into 7 channel-groups:
 
 #### Status
 
-| Channel                | Type   | Description                                                                                  |
-|------------------------|--------|----------------------------------------------------------------------------------------------|
-| Global State           | String | State of heat pump as String taken from Kermi Documentation (german wording)                 |
-| Global State as Number | Number | State of heat pump as Number, better for checking / integration as the State as String above |
+| Channel         | Type   | Description                                                          |
+|-----------------|--------|----------------------------------------------------------------------|
+| Global State ID | Number | State of heat pump as Number, displayed as readable State-Text in UI |
 
 Possible states:
 
@@ -181,14 +180,18 @@ Possible states:
 ### Persistence
 
 You can / should persist some items you want to track, maybe you track your power consumption with another device (PV-System or 'smart' electricity meter), so you can compare these values.
-As these values are long-running ones, maybe you should invest a little amount of time using influx as persistance (additionally to your existing). Influx DB is the best storage for long terms and uses very small space for its data. Please read the documentation for better understanding how it works.
+As these values are long-running ones, maybe you should invest a little amount of time using influx as persistance (additionally to your existing). 
+Influx DB is the best storage for long terms and uses very small space for its data. Please read the documentation for better understanding how it works.
 
-Simple: Install influxDB (>2.x) on a system within your network and enter your configuration settings in openhab using the influxdb-binding. As you do not track that mass of data you can use a raspberry pi with and SSD attaches to it (do NOT use an SD-card as database-storage). 
+Simple: Install influxDB (>2.x) on a system within your network and enter your configuration settings in openhab using the influxdb-binding. 
+As you do not track that mass of data you can use a raspberry pi with and SSD attaches to it (do NOT use an SD-card as database-storage). 
 
 ### Visualization
 
-As many other users I like and use the Grafana approach (in combination with influxdb). See here for more information [InfluxDB & Grafana Tutorial](https://community.openhab.org/t/influxdb-grafana-persistence-and-graphing/13761)
+As many other users I like and use the Grafana approach (in combination with influxdb). 
+See here for more information [InfluxDB & Grafana Tutorial](https://community.openhab.org/t/influxdb-grafana-persistence-and-graphing/13761)
 
 ### Credits
 
-Credits goes to Bernd Weymann (Author of E3DC-Modbus-Binding). I used its basic structure / code and handling of Modbus Messages for this binding. Thanks.
+Credits goes to Bernd Weymann (Author of E3DC-Modbus-Binding). 
+I used its basic structure / code and handling of Modbus Messages for this binding. Thanks.
diff --git a/...ng.modbus.kermi/src/main/java/org/openhab/binding/modbus/kermi/internal/dto/AlarmDTO.java b/...ng.modbus.kermi/src/main/java/org/openhab/binding/modbus/kermi/internal/dto/AlarmDTO.java
@@ -29,6 +29,6 @@ public class AlarmDTO implements Data {
 
     public AlarmDTO(byte[] bArray) {
         int status = ModbusBitUtilities.extractBit(bArray, ALARM_REG_SIZE);
-        alarmIsActive = status == 0 ? OnOffType.OFF : OnOffType.ON;
+        alarmIsActive = OnOffType.from(status != 0);
     }
 }
diff --git a/...ng.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-chargingcircuit-channel-types.xml b/...ng.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-chargingcircuit-channel-types.xml
@@ -5,19 +5,19 @@
 	xsi:schemaLocation="https://openhab.org/schemas/thing-description/v1.0.0 https://openhab.org/schemas/thing-description-1.0.0.xsd">
 	<channel-type id="flow-temperature-channel">
 		<item-type>Number:Temperature</item-type>
-		<label>Flow temperature</label>
+		<label>Flow Temperature</label>
 		<description>B16 - Vorlauftemperatur WP</description>
 		<state pattern="%.1f %unit%"/>
 	</channel-type>
 	<channel-type id="return-temperature-channel">
 		<item-type>Number:Temperature</item-type>
-		<label>Return temperature</label>
+		<label>Return Temperature</label>
 		<description>B17 - Rücklauftemperatur WP</description>
 		<state pattern="%.1f %unit%"/>
 	</channel-type>
 	<channel-type id="flow-speed-channel">
 		<item-type>Number:VolumetricFlowRate</item-type>
-		<label>Flow speed</label>
+		<label>Flow Speed</label>
 		<description>P13 - Durchfluss WP in l/min</description>
 		<state pattern="%.1f %uni%"/>
 	</channel-type>

diff --git a/...nding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-energysource-channel-types.xml b/...nding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-energysource-channel-types.xml
@@ -5,7 +5,7 @@
 	xsi:schemaLocation="https://openhab.org/schemas/thing-description/v1.0.0 https://openhab.org/schemas/thing-description-1.0.0.xsd">
 	<channel-type id="exit-temperature-channel">
 		<item-type>Number:Temperature</item-type>
-		<label>Exit temperature</label>
+		<label>Exit Temperature</label>
 		<description>B14 - Energiequelle Austrittstemperatur</description>
 	</channel-type>
 	<channel-type id="incoming-temperature-channel">

diff --git a/...hab.binding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-power-channel-groups.xml b/...hab.binding.modbus.kermi/src/main/resources/OH-INF/thing/xcenter-power-channel-groups.xml
@@ -4,7 +4,7 @@
 	xmlns:thing="https://openhab.org/schemas/thing-description/v1.0.0"
 	xsi:schemaLocation="https://openhab.org/schemas/thing-description/v1.0.0 https://openhab.org/schemas/thing-description-1.0.0.xsd">
 	<channel-group-type id="xcenter-power-values">
-		<label>Power and efficency</label>
+		<label>Power & Efficiency</label>
 		<description>Information about power and efficiency</description>
 		<channels>
 			<channel id="cop" typeId="cop-channel"/>