[kermi] Initial contribution #15687
[kermi] Initial contribution #15687
Conversation
florian-h05
changed the title
florian-h05
added
the
new binding
Signed-off-by: Marco Descher <marco@descher.at>
Signed-off-by: Marco Descher <marco@descher.at>
Signed-off-by: Marco Descher <marco@descher.at>
Signed-off-by: Marco Descher <marco@descher.at>
col-panic
force-pushed
the
15680-kermi
branch
from
b28d045
to
69db59c
Compare
|
@col-panic - thanks for your contribution! Until this PR will picked up for review, you could already have a look at the checkstyle warnings. See target/code-analysis/report.html. |
|
I fixed some of those. Some of them don't make sense to me. Why is lang3.Stringutils provided, but should not be used? |
See #7722. |
|
|
||
| * a franchised version of the Kermi heatpump, namely the [Heizbösch MOZART13AC-RW60](https://www.boesch.at/produkte/heizen/waermepumpe/luft/modulierende-luft-wasser-waermepumpe-mozart-aussenaufstellung~495589) heatpump manager version _1.6.0.118_ . | ||
|
|
||
| No official documentation could be found or gathered. This plug-in is based |
There was a problem hiding this comment.
Every sentence has to be on its own line. Please adjust all in this file.
| Number:Power Current_Power_Inverter {channel="kermi:heatpump:heatpumpbridge:heatpump:Rubin_CurrentPowerInverter"} | ||
| ``` | ||
|
|
||
| # Changelog |
There was a problem hiding this comment.
changelog is not needed as git is used for release notes.
| * Support string values for datapointType = 3 | ||
| * Support string values for datapointType = 4 | ||
|
|
||
| # ToDo / Future Tasks |
There was a problem hiding this comment.
please implement or create github issues for each todo item.
| ``` | ||
| // kermi.items | ||
| Number:Temperature Drinking_water_temperature {channel="kermi:drinkingwater-heating:heatpumpbridge:dwheating:BufferSystem_TweTemperatureActual"} | ||
|
|
|
|
||
| Number:Temperature Heating_current_temperature_buffer {channel="kermi:room-heating:heatpumpbridge:rheating:BufferSystem_HeatingTemperatureActual"} | ||
| Number:Temperature Cooling_current_temperature_buffer {channel="kermi:room-heating:heatpumpbridge:rheating:BufferSystem_CoolingTemperatureActual"} | ||
|
|
| @SuppressWarnings("null") | ||
| public synchronized String executeUrl(String httpMethod, String url, String content, String contentType) | ||
| throws KermiCommunicationException { | ||
| if (StringUtils.isBlank(hostname)) { |
There was a problem hiding this comment.
| if (StringUtils.isBlank(hostname)) { | |
| if (hostname == null || hostname.isBlank()) { |
| } | ||
|
|
||
| private String getBaseApiUrl() { | ||
| return "http://" + hostname + "/api/"; |
There was a problem hiding this comment.
Not 100% sure, but maybe you can re-use something from the binding constants class as this api url creation /parsing looks like duplicate functionality.
| ? new ByteArrayInputStream(content.getBytes(StandardCharsets.UTF_8)) | ||
| : null; | ||
| result = HttpUtil.executeUrl(httpMethod, url, httpHeaders, inputStream, contentType, 5000); | ||
| logger.debug("[{} {}] {}", httpMethod, url, result); |
There was a problem hiding this comment.
when logging extensive details as results/body etc it is advised to use trace level.
| if (iex != null && iex.getCause() instanceof HttpResponseException) { | ||
| HttpResponseException hre = (HttpResponseException) iex.getCause(); | ||
| if (401 == hre.getResponse().getStatus()) { | ||
| logger.debug("Perform login"); |
There was a problem hiding this comment.
better to move this debugging inside the performlogin method itself as that method is responsible for such a task.
| } | ||
|
|
||
| logger.debug("HTTP error on attempt #{} {}", attemptCount, url); | ||
| Thread.sleep(500 * attemptCount); |
There was a problem hiding this comment.
Are you sure you want to block the thread? why not use the scheduler? If this code is called on binding initilization, this is a no go. (i can check, but have to go now)
Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: Marco Descher <marco@descher.at>
|
@col-panic are you able to proceed with the first comments and fix the build? If not, let me know and see what we can do to get this fixed. |
|
Hey @lsiepel feel free to perform changes. I've been using the code for a while for myself. At the moment I do not see a time slot to continue! It would be best, however, if someone could co-test the code if he has the same device. |
|
As of the current info, this PR will be closed in the future in favour of #16329 |
Kermi Binding
Description
This binding connects to Kermi x-center controller for heat pumps.