[Broadlink] Initial contribution #16273

AntonJansen · 2024-01-13T18:58:06Z

Title

[Broadlink] A binding that can communicate with the Broadlink family of WiFi-addressable devices

Description

The binding support the following devices:

A1 environmental sensor
RMx Remote IR blasters
SPx WiFi-controlled power switches
MPx WiFi-controlled multi-outlet power strips

This pull request is an update of the stalled pull request #14582, updated for 4.2.x

The discussion for this pull request is:
https://community.openhab.org/t/broadlink-binding-4-1-0-4-2-0/154734

Signed-off-by: Anton Jansen mail@antonjansen.com

Signed-off-by: AntonJansen <gradius@fmf.nl>

…nes. Signed-off-by: AntonJansen <gradius@fmf.nl>

…will work. Signed-off-by: AntonJansen <gradius@fmf.nl>

Signed-off-by: AntonJansen <gradius@fmf.nl>

- a reference to https:// that should have been http:// for xsi:schemaLocation - a double copyright reference - an empty line that should not be there Signed-off-by: AntonJansen <gradius@fmf.nl>

openhab-bot · 2024-01-14T15:13:47Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh-4-0-4-broadlink-binding-rm3-mini-error/152173/16

- Add new device type to model mapper - Fix bug with mac address being send in wrong order - Added trace logging information to track messages Signed-off-by: AntonJansen <gradius@fmf.nl>

Cleaned up the code. Signed-off-by: AntonJansen <gradius@fmf.nl>

…tion. Signed-off-by: AntonJansen <gradius@fmf.nl>

Signed-off-by: AntonJansen <gradius@fmf.nl>

Skinah

Please go through all uses of the logger and fix.

Also after you have built the binding look in the target folder where the jar appears.
Folder called target\code-analysis
open the file called report.html
Then try and fix as many as you can whilst you wait for more review comments.

Thanks for taking on the binding.

...inding.broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkA1Handler.java

...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java

…b/binding/broadlink/handler/BroadlinkA1Handler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Ensure actual message is included in logging Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Signed-off-by: AntonJansen <gradius@fmf.nl>

lsiepel · 2024-09-19T21:17:24Z

I guess the commits where made through the Github web interface. When not properly configured, this causes the DCO to fail because of missing signoff. Unfortunately the suggestions had some whitespace issues so spotless is also complaining.

Hopefully you manage to rewrite the commit messages with a signoff and fix the spotless issue. I would also ask you to have a test run after all these change have been applied. It will not be the first and last time my suggestions lead to regression.

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…F/thing/rm-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…F/thing/channels.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…hab-addons into broadlink-binding-4.2.x

…ing issues. Signed-off-by: AntonJansen <gradius@fmf.nl>

AntonJansen · 2024-09-29T18:42:44Z

@lsiepel I should have addressed all your comments now. The main thing left is the DCO, which is due to Ricardo Larranaga, which did not use the proper sign-off. I have been trying to reach him the last 6 months, but no luck thus far.

Signed-off-by: AntonJansen <gradius@fmf.nl>

lsiepel · 2024-09-29T19:50:56Z

@lsiepel I should have addressed all your comments now. The main thing left is the DCO, which is due to Ricardo Larranaga, which did not use the proper sign-off. I have been trying to reach him the last 6 months, but no luck thus far.

I’ll try to have another look next week.

lsiepel

Finished reviewing the last files, also found some other improvements. I think this is the last iteration, a lot of work has been done. Thank you for adapting the improvements regarding the excessive reachability checks. Much better now.

bundles/org.openhab.binding.broadlink/README.md

...rc/main/java/org/openhab/binding/broadlink/internal/config/BroadlinkDeviceConfiguration.java

bundles/org.openhab.binding.broadlink/README.md

...hab.binding.broadlink/src/main/java/org/openhab/binding/broadlink/internal/NetworkUtils.java

.../src/main/java/org/openhab/binding/broadlink/internal/handler/BroadlinkBaseThingHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…b/binding/broadlink/internal/config/BroadlinkDeviceConfiguration.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…b/binding/broadlink/internal/NetworkUtils.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

…b/binding/broadlink/internal/handler/BroadlinkBaseThingHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Signed-off-by: AntonJansen <gradius@fmf.nl>

…hab-addons into broadlink-binding-4.2.x

Signed-off-by: AntonJansen <gradius@fmf.nl>

AntonJansen · 2024-10-14T19:46:34Z

@lsiepel I resolved all the issues apart from one, for which I need a bit more input.

Signed-off-by: AntonJansen <gradius@fmf.nl>

AntonJansen · 2024-10-15T20:47:07Z

@lsiepel all known issues should now have been resolved. Let me know what to do next.

AntonJansen · 2024-10-16T18:19:12Z

@Skinah All your requested changes should have been completed. Please confirm, so we can wrap-up this pull request.

lsiepel · 2024-10-16T19:55:56Z

Thanks, now this is merged, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

AntonJansen requested a review from a team as a code owner January 13, 2024 18:58

lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 13, 2024

AntonJansen force-pushed the broadlink-binding-4.2.x branch from 8264a68 to 9db5bef Compare January 14, 2024 13:41

AntonJansen added 3 commits January 14, 2024 15:03

Initial import of the broadlink binding for openhab 4.2

ee60cd1

Signed-off-by: AntonJansen <gradius@fmf.nl>

Cleaned up the binding information files to confirm to coding guideli…

53517db

…nes. Signed-off-by: AntonJansen <gradius@fmf.nl>

Added missing artifact to the bom pom.xml such that the CI hopefully …

3acad3f

…will work. Signed-off-by: AntonJansen <gradius@fmf.nl>

AntonJansen force-pushed the broadlink-binding-4.2.x branch from 633a698 to 3acad3f Compare January 14, 2024 14:03

AntonJansen added 2 commits January 14, 2024 15:10

Updated the copyright notice from 2023 to 2024. Happy new year!

5ec10d7

Signed-off-by: AntonJansen <gradius@fmf.nl>

Fixed:

d5dc281

- a reference to https:// that should have been http:// for xsi:schemaLocation - a double copyright reference - an empty line that should not be there Signed-off-by: AntonJansen <gradius@fmf.nl>

lsiepel mentioned this pull request Jan 14, 2024

[broadlink] Broadlink binding #14582

Closed

lsiepel changed the title ~~[Broadlink] Broadlink binding 4.2.x~~ [Broadlink] Initial contribution Jan 14, 2024

AntonJansen added 6 commits January 23, 2024 20:13

Fixed an issue with a new RM Pro 4 not working. Changes include:

9c8b29d

- Add new device type to model mapper - Fix bug with mac address being send in wrong order - Added trace logging information to track messages Signed-off-by: AntonJansen <gradius@fmf.nl>

Created a distinction between a RM 4 Mini and RM 4 Pro.

839a384

Cleaned up the code. Signed-off-by: AntonJansen <gradius@fmf.nl>

Add forgotten files for introduction to new RM 4 Mini and Pro distinc…

afdb598

…tion. Signed-off-by: AntonJansen <gradius@fmf.nl>

Fixed missing copyright header

8e8bd11

Signed-off-by: AntonJansen <gradius@fmf.nl>

Added missing author.

e85a786

Signed-off-by: AntonJansen <gradius@fmf.nl>

Added missing @nonbydefault for new class

4d5cf72

Signed-off-by: AntonJansen <gradius@fmf.nl>

Skinah requested changes Jan 27, 2024

View reviewed changes

AntonJansen and others added 11 commits January 27, 2024 13:56

Busy creating a new structure for the rm pro types.

4493fb0

Signed-off-by: AntonJansen <gradius@fmf.nl>

Fixed SAT errors.

af65950

Signed-off-by: AntonJansen <gradius@fmf.nl>

Cleaned up unnecessary log entries.

37974e0

Signed-off-by: AntonJansen <gradius@fmf.nl>

AntonJansen and others added 5 commits September 29, 2024 17:20

Update bundles/org.openhab.binding.broadlink/README.md

82f1dba

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Update bundles/org.openhab.binding.broadlink/src/main/resources/OH-IN…

d41899a

…F/thing/rm-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Update bundles/org.openhab.binding.broadlink/src/main/resources/OH-IN…

4eefd5f

…F/thing/channels.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Merge branch 'broadlink-binding-4.2.x' of github.com:AntonJansen/open…

664b6a3

…hab-addons into broadlink-binding-4.2.x

Resolved all the comments received thus far and resolved all the merg…

2d4bbf9

…ing issues. Signed-off-by: AntonJansen <gradius@fmf.nl>

Updated the reference to Ricardo Larranaga.

0ebe83b

Signed-off-by: AntonJansen <gradius@fmf.nl>

lsiepel removed the awaiting feedback label Oct 2, 2024

lsiepel requested changes Oct 2, 2024

View reviewed changes

AntonJansen and others added 11 commits October 14, 2024 19:55

Update bundles/org.openhab.binding.broadlink/README.md

25930d9

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Update bundles/org.openhab.binding.broadlink/README.md

b2b45d3

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Update bundles/org.openhab.binding.broadlink/src/main/java/org/openha…

9de76eb

…b/binding/broadlink/internal/config/BroadlinkDeviceConfiguration.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Update bundles/org.openhab.binding.broadlink/src/main/java/org/openha…

585eecb

…b/binding/broadlink/internal/config/BroadlinkDeviceConfiguration.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Update bundles/org.openhab.binding.broadlink/README.md

c2c7154

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Update bundles/org.openhab.binding.broadlink/src/main/java/org/openha…

9f06148

…b/binding/broadlink/internal/NetworkUtils.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Update bundles/org.openhab.binding.broadlink/src/main/java/org/openha…

2b24d50

…b/binding/broadlink/internal/handler/BroadlinkBaseThingHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Anton Jansen <AntonJansen@users.noreply.github.com>

Changed the name of the item types.

306dce7

Signed-off-by: AntonJansen <gradius@fmf.nl>

Merge branch 'broadlink-binding-4.2.x' of github.com:AntonJansen/open…

9194d0e

…hab-addons into broadlink-binding-4.2.x

Added a timeout on finding an available port.

c3d7819

Signed-off-by: AntonJansen <gradius@fmf.nl>

Updated language file to reflect renaming of the type of things.

f7417ff

Signed-off-by: AntonJansen <gradius@fmf.nl>

Expanded documentation with an example of IR AC control.

19f67b2

Signed-off-by: AntonJansen <gradius@fmf.nl>

lsiepel approved these changes Oct 15, 2024

View reviewed changes

lsiepel merged commit e32fccb into openhab:main Oct 16, 2024
4 of 5 checks passed

lsiepel added this to the 4.3 milestone Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Broadlink] Initial contribution #16273

[Broadlink] Initial contribution #16273

AntonJansen commented Jan 13, 2024 •

edited

Loading

openhab-bot commented Jan 14, 2024

Skinah left a comment

lsiepel commented Sep 19, 2024 •

edited

Loading

AntonJansen commented Sep 29, 2024 •

edited

Loading

lsiepel commented Sep 29, 2024

lsiepel left a comment

AntonJansen commented Oct 14, 2024

AntonJansen commented Oct 15, 2024

AntonJansen commented Oct 16, 2024

lsiepel commented Oct 16, 2024

[Broadlink] Initial contribution #16273

[Broadlink] Initial contribution #16273

Conversation

AntonJansen commented Jan 13, 2024 • edited Loading

Title

Description

openhab-bot commented Jan 14, 2024

Skinah left a comment

Choose a reason for hiding this comment

lsiepel commented Sep 19, 2024 • edited Loading

AntonJansen commented Sep 29, 2024 • edited Loading

lsiepel commented Sep 29, 2024

lsiepel left a comment

Choose a reason for hiding this comment

AntonJansen commented Oct 14, 2024

AntonJansen commented Oct 15, 2024

AntonJansen commented Oct 16, 2024

lsiepel commented Oct 16, 2024

AntonJansen commented Jan 13, 2024 •

edited

Loading

lsiepel commented Sep 19, 2024 •

edited

Loading

AntonJansen commented Sep 29, 2024 •

edited

Loading