-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[huesync] Hue Play HDMI Sync Box Binding - Initial contribution #16516
base: main
Are you sure you want to change the base?
Conversation
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/philips-hdmi-sync-api/111679/39 |
edf4eb7
to
565fc72
Compare
@pgfeller I will start to look at this tomorrow. |
565fc72
to
ba801a2
Compare
@andrewfg Thanks! Take your time - progress will be slow unfortunately; as free time is a rare commodity ... |
566ee5d
to
a42500f
Compare
.../java/org/openhab/binding/huesync/internal/api/dto/device/HueSyncDeteiledDeviceInfoWifi.java
Outdated
Show resolved
Hide resolved
...huesync/src/main/java/org/openhab/binding/huesync/internal/connection/HueSyncConnection.java
Show resolved
Hide resolved
...huesync/src/main/java/org/openhab/binding/huesync/internal/connection/HueSyncConnection.java
Outdated
Show resolved
Hide resolved
...huesync/src/main/java/org/openhab/binding/huesync/internal/connection/HueSyncConnection.java
Outdated
Show resolved
Hide resolved
186bd73
to
0549ac6
Compare
@andrewfg Hi Andrew, I hope you are fine! I'm not sure if you're following the progress of the implementation from time to time. I've finished most of the infrastructure that I plan to use in the binding. Next I'll will implement the most important channels that are relevant for automation (this PR will not support all the available options the API provides). I'm a little bit unhappy - as I do not manage to provide/declare all the relevant information in the .xml definitions to automatically create a nice semantic model. Is this a limitation (no problem - but then I can stop to investigate) ... - or do I miss something in the .xml structure? I've found that there is an advanced configuration option in the UI to add channels from the equipment (very cool). I will use this in the readme to show how to structure things (here comments are also very welcome - as I'm still not familiar enough with the semantic types and properties etc ... I think the biggest problem of OH is, that most people (including me) are not aware how powerful it is what it is capable of ... e.g. today I learned that it is possible to use f7 and other icons via advanced UI configuration ... with kind regards, |
I am not sure what you think is missing? Perhaps have a look at the example below.. |
Thank you for the example; I've also checked the .xsd definitions - but it seems that I've already added all the info I can. When the equipment/items are automatically created it does not look as nice as I would like to have it ... but that's not a huge problem. With the manual configuration I've added to the readme the representation in the model looks nice. I'll keep it as is for the moment and continue with channel implementations to get functionality into the thing 🙂. I already use the alpha for some 1st simple automation tasks 👍. Let me know if you see something I should change from a Java/openHAB framework perspective ... the infra is approaching its final shape; so I do not see any major gaps anymore in that area. |
This comment was marked as outdated.
This comment was marked as outdated.
All seems sorted now. There might be better workflows, but i usually update the main brnach of my github fork from upstream openhab via the Github website. Then i update the main branch on my local dev machine, to finally update the feature branch on my local dev machine. I never need to force push. Maybe this helps a little bit. Anyway, all got sorted, there are some (burried) review comments behind load more buttons so if you can address those, we can proceed with this PR. |
Renamed artifactId in pom.xml according to code review comment. Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
THING_TYPE_ID updated according to review comment Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
- THING_TYPE_ID updated according to review comment (fixed typo) - label suggestions applied to channel-types Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Default values for channel-type **connection-type** added. Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Default values for channel-type **connection-type** added. Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
This binding integrates the Play HDMI Sync Box into openHAB. The integration happens directly through the Hue HDMI Sync Box API.
The binding is using mDNS to discover HDMI Sync devices in the local network. The LED on the Sync Box must be white or red. This indicates that the device is connected to the Network. If the LED is blinking blue, you need to setup the device using the official Hue Sync App.
Community discussion thread: Philips HDMI Sync API
Closes #10218
Credits
Tasks
AuthenticationStore
✅on
/off
mode
ℹ️: The 1st version will not support all possible functions - as the basic setup can be done via the official App ➡️ - I'll focus on status information and commands that are most relevant for automation in this PR.